From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CB0A1E5B68; Wed, 4 Mar 2026 12:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772628492; cv=none; b=T7JMNVU4O0qVbH+hZ9kFF873vfg8YZHC4ZBEWq2YPicKQaZk0MYgQI1Xu9yCJZ7zCZOeEGN3McuAhahB0GJAZZeVlgD4Jj6eLOmdMH26fbP9oytkinlRcacgCm/9JCq+b13GJQjwrplm80iMsoli8ySrDEy3HHqTXMb0hY9SYgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772628492; c=relaxed/simple; bh=ZqxKumdP+DNsxXXslcjyg5g3aU/VfpjJU2mvzXFg4hE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dy1SJW5kA264gHFLvdfEHrvMBsl4yppJR340k91AqnYcVap1dAXWhIak3rsYMddSlzDUlzdjHUKDt14MzyMWl2c1p8kyFSgZjnr41TdafcLhb+dJL9a3MHPgoUnqPjKaB8EdGKMbnUREn8kMH2aJr1CMLZvQ/zCztAIVI4/mbeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=U5NhpZCn; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="U5NhpZCn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YsXg2qDZ+ZjnQnj/eNfiIgU3SLUyimkRR7bx5y5oB4w=; b=U5NhpZCn934XojSyVFL1nj1S/W 2SwNvFKnKgDXQSzq6m51IMvSlZX+ne4bEh4E01vZtYgpLee5ixUDi8qEHb4R97fy2f4d2ReNAtXFl 2Myy/FM9yjpIi4F5MCjGcXNEoyN2WDgyc7039UPkredIXwYhk1etVNasHnwai+IB6c4ro8VQTd24m dlAjACdWYLWNFfSy+VdBxKivYhNczBRSHxMPHao0CvqQusPNjCznq/i4rksmb+FqExqEhxu3s5ruZ HIicL8wW2i2h8YBWX0vQS1a34HK9wPAQFs79TabY9VaeD6tSKbvzAdMAvOXPYXBWy7iVhi1jbb7PJ KVa5pNSQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxle2-00000004Z41-2FWR; Wed, 04 Mar 2026 12:48:06 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 07040300666; Wed, 04 Mar 2026 13:48:06 +0100 (CET) Date: Wed, 4 Mar 2026 13:48:05 +0100 From: Peter Zijlstra To: Sean Christopherson Cc: Jens Axboe , Jakub Kicinski , Yury Norov , Andrew Morton , "David S. Miller" , "Michael S. Tsirkin" , Theodore Ts'o , Albert Ou , Alexander Duyck , Alexander Gordeev , Alexander Viro , Alexandra Winter , Andreas Dilger , Andrew Lunn , Anna Schumaker , Anton Yakovlev , Arnaldo Carvalho de Melo , Aswin Karuvally , Borislav Petkov , Carlos Maiolino , Catalin Marinas , Chao Yu , Christian Borntraeger , Christian Brauner , Claudio Imbrenda , Dave Hansen , David Airlie , Dominique Martinet , Dongsheng Yang , Eric Dumazet , Eric Van Hensbergen , Heiko Carstens , Herbert Xu , Ingo Molnar , Jaegeuk Kim , Jani Nikula , Janosch Frank , Jaroslav Kysela , Joonas Lahtinen , Latchesar Ionkov , Linus Walleij , Madhavan Srinivasan , Mark Brown , Michael Ellerman , Miklos Szeredi , Namhyung Kim , Palmer Dabbelt , Paolo Abeni , Paolo Bonzini , Paul Walmsley , Rodrigo Vivi , Simona Vetter , Takashi Iwai , Thomas Gleixner , Trond Myklebust , Tvrtko Ursulin , Vasily Gorbik , Will Deacon , Yury Norov , Zheng Gu , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, dm-devel@lists.linux.dev, netdev@vger.kernel.org, linux-spi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, v9fs@lists.linux.dev, virtualization@lists.linux.dev, linux-sound@vger.kernel.org Subject: Re: [PATCH 0/8] mm: globalize rest_of_page() macro Message-ID: <20260304124805.GB2277644@noisy.programming.kicks-ass.net> References: <20260304012717.201797-1-ynorov@nvidia.com> <20260303182845.250bb2de@kernel.org> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 03, 2026 at 06:49:36PM -0800, Sean Christopherson wrote: > On Tue, Mar 03, 2026, Jens Axboe wrote: > > On 3/3/26 7:28 PM, Jakub Kicinski wrote: > > > On Tue, 3 Mar 2026 20:27:08 -0500 Yury Norov wrote: > > >> The net/9p networking driver has a handy macro to calculate the > > >> amount of bytes from a given pointer to the end of page. Move it > > >> to core/mm, and apply tree-wide. No functional changes intended. > > >> > > >> This series was originally introduced as a single patch #07/12 in: > > >> > > >> https://lore.kernel.org/all/20260219181407.290201-1-ynorov@nvidia.com/ > > >> > > >> Split it for better granularity and submit separately. > > > > > > I don't get what the motivation is here. Another helper developers > > > and readers of the code will need to know about just to replace > > > obvious and easy to comprehend math. > > > > I fully agree, I had the same thought reading this. > > +1 from KVM-land. Right, this. I hate these pointless helpers that obscure perfectly sensible and obvious code -- and for me that includes things like rounddown() and DIV_ROUND_UP(). It just makes the code harder to read. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CE70EF8FEA for ; Wed, 4 Mar 2026 13:54:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iqERoYo+osHscluuOXGf4wLNYrXH2uPGjfwR60IwDxY=; b=kPEeQf90BC7mWiZrZMx8O84Xwb Fz7TyRKKYIbAAKSRbZmD5pabY36zW3QAngUwpH62/Kflo1mVHffK9AUke6vjDOvn9F6hljNhpV3K7 C9+s7m4ARhwAgKKW9JtKdGHGW3eb1S6slaHcmJ7QhfpmMTz80z+0lDPp0ayx6Vp5EkjI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxmgY-0006Fc-Go; Wed, 04 Mar 2026 13:54:46 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxmgV-0006FT-OF for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Mar 2026 13:54:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YsXg2qDZ+ZjnQnj/eNfiIgU3SLUyimkRR7bx5y5oB4w=; b=UcTByFDmKH7nyH3nhg6FSmVJBq XNseHOSH/p+lplma01S2GHczPp6AEq+8403/Sh95aHwcsxqEB1umkcp+OloohoD27uhclAQlIMSL6 wQA1WhZxZfdRZmoyXMFdlfd1CK2ibpQLZBh5Rc32j8ekp6XVBtDpIU09EKMQw8oQgYqU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YsXg2qDZ+ZjnQnj/eNfiIgU3SLUyimkRR7bx5y5oB4w=; b=D8LqtcJAI433iHgml4ODErPYyI qTQLxhtFhrZdbIAuNC8bYx+9Uw+41ys3zsZFmEYjt4PEmMX92Ksxu9vdigApzhzPxZWFZW/Yk3zhT RoahSfx9XtyPg7bQle4GbU0ikhVQ9PXdkLVK0u4kQI2wEJ5/4L2puRFC6XS/6bxejHPw=; Received: from desiato.infradead.org ([90.155.92.199]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxmgU-0003Na-TA for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Mar 2026 13:54:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YsXg2qDZ+ZjnQnj/eNfiIgU3SLUyimkRR7bx5y5oB4w=; b=U5NhpZCn934XojSyVFL1nj1S/W 2SwNvFKnKgDXQSzq6m51IMvSlZX+ne4bEh4E01vZtYgpLee5ixUDi8qEHb4R97fy2f4d2ReNAtXFl 2Myy/FM9yjpIi4F5MCjGcXNEoyN2WDgyc7039UPkredIXwYhk1etVNasHnwai+IB6c4ro8VQTd24m dlAjACdWYLWNFfSy+VdBxKivYhNczBRSHxMPHao0CvqQusPNjCznq/i4rksmb+FqExqEhxu3s5ruZ HIicL8wW2i2h8YBWX0vQS1a34HK9wPAQFs79TabY9VaeD6tSKbvzAdMAvOXPYXBWy7iVhi1jbb7PJ KVa5pNSQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxle2-00000004Z41-2FWR; Wed, 04 Mar 2026 12:48:06 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 07040300666; Wed, 04 Mar 2026 13:48:06 +0100 (CET) Date: Wed, 4 Mar 2026 13:48:05 +0100 From: Peter Zijlstra To: Sean Christopherson Message-ID: <20260304124805.GB2277644@noisy.programming.kicks-ass.net> References: <20260304012717.201797-1-ynorov@nvidia.com> <20260303182845.250bb2de@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1vxmgU-0003Na-TA Subject: Re: [f2fs-dev] [PATCH 0/8] mm: globalize rest_of_page() macro X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Zheng Gu , kvm@vger.kernel.org, "Michael S. Tsirkin" , Catalin Marinas , Alexander Duyck , Dave Hansen , dri-devel@lists.freedesktop.org, Jaroslav Kysela , linux-perf-users@vger.kernel.org, linux-mm@kvack.org, Eric Dumazet , Andreas Dilger , linux-nfs@vger.kernel.org, Dongsheng Yang , Joonas Lahtinen , Alexander Gordeev , Claudio Imbrenda , David Airlie , linux-riscv@lists.infradead.org, Simona Vetter , linux-s390@vger.kernel.org, Madhavan Srinivasan , Yury Norov , Herbert Xu , Alexandra Winter , Miklos Szeredi , Michael Ellerman , linux-ext4@vger.kernel.org, x86@kernel.org, Yury Norov , Tvrtko Ursulin , linux-spi@vger.kernel.org, Jani Nikula , Ingo Molnar , Aswin Karuvally , intel-gfx@lists.freedesktop.org, Jakub Kicinski , Christian Borntraeger , Carlos Maiolino , Dominique Martinet , Thomas Gleixner , dm-devel@lists.linux.dev, Albert Ou , Vasily Gorbik , Heiko Carstens , Will Deacon , linux-f2fs-devel@lists.sourceforge.net, Arnaldo Carvalho de Melo , linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, Mark Brown , Borislav Petkov , Alexander Viro , Rodrigo Vivi , Jaegeuk Kim , virtualization@lists.linux.dev, Eric Van Hensbergen , Paul Walmsley , linux-arm-kernel@lists.infradead.org, Janosch Frank , Jens Axboe , Christian Brauner , Paolo Abeni , Theodore Ts'o , v9fs@lists.linux.dev, netdev@vger.kernel.org, Linus Walleij , linux-sound@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, Andrew Lunn , Palmer Dabbelt , Anton Yakovlev , Anna Schumaker , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Namhyung Kim , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Trond Myklebust Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Mar 03, 2026 at 06:49:36PM -0800, Sean Christopherson wrote: > On Tue, Mar 03, 2026, Jens Axboe wrote: > > On 3/3/26 7:28 PM, Jakub Kicinski wrote: > > > On Tue, 3 Mar 2026 20:27:08 -0500 Yury Norov wrote: > > >> The net/9p networking driver has a handy macro to calculate the > > >> amount of bytes from a given pointer to the end of page. Move it > > >> to core/mm, and apply tree-wide. No functional changes intended. > > >> > > >> This series was originally introduced as a single patch #07/12 in: > > >> > > >> https://lore.kernel.org/all/20260219181407.290201-1-ynorov@nvidia.com/ > > >> > > >> Split it for better granularity and submit separately. > > > > > > I don't get what the motivation is here. Another helper developers > > > and readers of the code will need to know about just to replace > > > obvious and easy to comprehend math. > > > > I fully agree, I had the same thought reading this. > > +1 from KVM-land. Right, this. I hate these pointless helpers that obscure perfectly sensible and obvious code -- and for me that includes things like rounddown() and DIV_ROUND_UP(). It just makes the code harder to read. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E3B9EB7ECF for ; Wed, 4 Mar 2026 12:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sJTo0y83WNKb/s9UQUMybwSUlRHk4oZ1vu0pRMnlEmY=; b=dK+QL5pqC0n/hq 3fqoOyurJaTp1H9N0jt4mufYmShbI84XaBXsu2e88/Mod65A+0FdSdcn2klINlImrIHIsOfBJQi2/ r4ZySSqhkNltsKDK0LgyLlTpkJ7TR6vq+YNQW3/hjIaGZnM0WRMxDgOt4e7hQqsQuFxCCsF951FIU 68V6F0Pb/G+mzbZFaPxpsgLktFP66lKi7dYsxtos2hUYLTeYQQYMx/sipleaSvsDFuWdO3Da2LasY eTpsJgYUoKV8GWvup5765Vl2glihBuXIeIQwjMuZNFsoDIK3p8m8cUXYK1DKChmhJs9Pot81PrJeS oFUwHYXMOatT4HkM5KSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxle7-0000000HCeM-2r6L; Wed, 04 Mar 2026 12:48:11 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxle5-0000000HCd7-3cqg; Wed, 04 Mar 2026 12:48:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YsXg2qDZ+ZjnQnj/eNfiIgU3SLUyimkRR7bx5y5oB4w=; b=U5NhpZCn934XojSyVFL1nj1S/W 2SwNvFKnKgDXQSzq6m51IMvSlZX+ne4bEh4E01vZtYgpLee5ixUDi8qEHb4R97fy2f4d2ReNAtXFl 2Myy/FM9yjpIi4F5MCjGcXNEoyN2WDgyc7039UPkredIXwYhk1etVNasHnwai+IB6c4ro8VQTd24m dlAjACdWYLWNFfSy+VdBxKivYhNczBRSHxMPHao0CvqQusPNjCznq/i4rksmb+FqExqEhxu3s5ruZ HIicL8wW2i2h8YBWX0vQS1a34HK9wPAQFs79TabY9VaeD6tSKbvzAdMAvOXPYXBWy7iVhi1jbb7PJ KVa5pNSQ==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxle2-00000004Z41-2FWR; Wed, 04 Mar 2026 12:48:06 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 07040300666; Wed, 04 Mar 2026 13:48:06 +0100 (CET) Date: Wed, 4 Mar 2026 13:48:05 +0100 From: Peter Zijlstra To: Sean Christopherson Cc: Jens Axboe , Jakub Kicinski , Yury Norov , Andrew Morton , "David S. Miller" , "Michael S. Tsirkin" , Theodore Ts'o , Albert Ou , Alexander Duyck , Alexander Gordeev , Alexander Viro , Alexandra Winter , Andreas Dilger , Andrew Lunn , Anna Schumaker , Anton Yakovlev , Arnaldo Carvalho de Melo , Aswin Karuvally , Borislav Petkov , Carlos Maiolino , Catalin Marinas , Chao Yu , Christian Borntraeger , Christian Brauner , Claudio Imbrenda , Dave Hansen , David Airlie , Dominique Martinet , Dongsheng Yang , Eric Dumazet , Eric Van Hensbergen , Heiko Carstens , Herbert Xu , Ingo Molnar , Jaegeuk Kim , Jani Nikula , Janosch Frank , Jaroslav Kysela , Joonas Lahtinen , Latchesar Ionkov , Linus Walleij , Madhavan Srinivasan , Mark Brown , Michael Ellerman , Miklos Szeredi , Namhyung Kim , Palmer Dabbelt , Paolo Abeni , Paolo Bonzini , Paul Walmsley , Rodrigo Vivi , Simona Vetter , Takashi Iwai , Thomas Gleixner , Trond Myklebust , Tvrtko Ursulin , Vasily Gorbik , Will Deacon , Yury Norov , Zheng Gu , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, dm-devel@lists.linux.dev, netdev@vger.kernel.org, linux-spi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, v9fs@lists.linux.dev, virtualization@lists.linux.dev, linux-sound@vger.kernel.org Subject: Re: [PATCH 0/8] mm: globalize rest_of_page() macro Message-ID: <20260304124805.GB2277644@noisy.programming.kicks-ass.net> References: <20260304012717.201797-1-ynorov@nvidia.com> <20260303182845.250bb2de@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Mar 03, 2026 at 06:49:36PM -0800, Sean Christopherson wrote: > On Tue, Mar 03, 2026, Jens Axboe wrote: > > On 3/3/26 7:28 PM, Jakub Kicinski wrote: > > > On Tue, 3 Mar 2026 20:27:08 -0500 Yury Norov wrote: > > >> The net/9p networking driver has a handy macro to calculate the > > >> amount of bytes from a given pointer to the end of page. Move it > > >> to core/mm, and apply tree-wide. No functional changes intended. > > >> > > >> This series was originally introduced as a single patch #07/12 in: > > >> > > >> https://lore.kernel.org/all/20260219181407.290201-1-ynorov@nvidia.com/ > > >> > > >> Split it for better granularity and submit separately. > > > > > > I don't get what the motivation is here. Another helper developers > > > and readers of the code will need to know about just to replace > > > obvious and easy to comprehend math. > > > > I fully agree, I had the same thought reading this. > > +1 from KVM-land. Right, this. I hate these pointless helpers that obscure perfectly sensible and obvious code -- and for me that includes things like rounddown() and DIV_ROUND_UP(). It just makes the code harder to read. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv