From: Jakub Kicinski <kuba@kernel.org>
To: "Jian Zhang" <zhangjian.3032@bytedance.com>
Cc: "Samuel Mendoza-Jonas" <sam@mendozajonas.com>,
"Paul Fertser" <fercerpav@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: ncsi: fix skb leak in error paths
Date: Wed, 4 Mar 2026 16:45:55 -0800 [thread overview]
Message-ID: <20260304164555.6253faf3@kernel.org> (raw)
In-Reply-To: <20260302054629.1347119-1-zhangjian.3032@bytedance.com>
On Mon, 2 Mar 2026 13:46:29 +0800 Jian Zhang wrote:
> +bail:
please give meaningful names to the labels, eg:
err_free_skb:
> + consume_skb(skb);
since this is a drop condition kfree_skb() seems more appropriate.
> + return ret;
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-05 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 5:46 [PATCH net] net: ncsi: fix skb leak in error paths Jian Zhang
2026-03-04 11:16 ` Simon Horman
2026-03-04 11:40 ` ByteDance
2026-03-05 0:45 ` Jakub Kicinski [this message]
2026-03-05 6:09 ` ByteDance
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304164555.6253faf3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sam@mendozajonas.com \
--cc=zhangjian.3032@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.