From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Cedric Jehasse via B4 Relay
<devnull+cedric.jehasse.luminex.be@kernel.org>,
cedric.jehasse@luminex.be, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5 1/2] net/sched: cls_flower: remove unions from fl_flow_key
Date: Wed, 4 Mar 2026 18:12:04 -0800 [thread overview]
Message-ID: <20260304181204.7b580afb@kernel.org> (raw)
In-Reply-To: <20260303-net-next-mv88e6xxx-tcam-v5-1-6f9129687276@luminex.be>
On Tue, 03 Mar 2026 14:18:23 +0100 Cedric Jehasse via B4 Relay wrote:
> When creating a flower classifier with an ipv4 address the
> flow_dissector has both FLOW_DISSECTOR_KEY_IPV4_ADDRS and
> FLOW_DISSECTOR_KEY_IPV6_ADDRS bits set in used_keys.
> This happens because ipv4/ipv6 fields are a union and
> FL_KEY_SET_IF_MASKED() will interpret either being set as both.
>
> Removing the unions fixes this behavior without needing special handling
> for union fields.
Jiri, this change is fine right?
next prev parent reply other threads:[~2026-03-05 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 13:18 [PATCH net-next v5 0/2] net: dsa: mv88e6xxx: Add partial support for TCAM entries Cedric Jehasse
2026-03-03 13:18 ` Cedric Jehasse via B4 Relay
2026-03-03 13:18 ` [PATCH net-next v5 1/2] net/sched: cls_flower: remove unions from fl_flow_key Cedric Jehasse
2026-03-03 13:18 ` Cedric Jehasse via B4 Relay
2026-03-05 2:12 ` Jakub Kicinski [this message]
2026-03-03 13:18 ` [PATCH net-next v5 2/2] net: dsa: mv88e6xxx: Add partial support for TCAM entries Cedric Jehasse
2026-03-03 13:18 ` Cedric Jehasse via B4 Relay
2026-03-05 2:12 ` [net-next,v5,2/2] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304181204.7b580afb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cedric.jehasse@luminex.be \
--cc=davem@davemloft.net \
--cc=devnull+cedric.jehasse.luminex.be@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.