All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Tarjan <paul@paultarjan.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, paul@paultarjan.com, jonathantanmy@google.com,
	hanxin.hx@bytedance.com, jeffhostetler@github.com,
	christian.couder@gmail.com
Subject: Re: [PATCH] promisor-remote: prevent lazy-fetch recursion in child fetch
Date: Wed,  4 Mar 2026 11:20:57 -0700	[thread overview]
Message-ID: <20260304182057.26463-1-github@paulisageek.com> (raw)
In-Reply-To: <xmqqikbb8pbd.fsf@gitster.g>

On Tue, Mar 4, 2026, Junio C Hamano wrote:
> I would suggest dropping these CC: lines from the proposed log
> message.  As far as I can see, they do not have their intended
> effect; [*1*] does not show any of these folks listed on Cc:

Done, moved them to the PR description for GitGitGadget to pick up.

> I also do not see much point in duplicating
> most of what appears in the proposed log message here after the
> three dash line, but that is a separate story.

Cleaned up the PR description to avoid the duplication.

> Hmph, do we really need an entirely new test script file dedicated
> for this single liner change, instead of adding to some existing
> test script that already covers related topics (like promisors and
> lazy fetches from them)?

Moved the test into t0411-clone-from-partial.sh, which already has
the other lazy-fetch tests. Dropped the separate t0412 file and the
meson.build entry.

  reply	other threads:[~2026-03-04 18:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 16:57 [PATCH] promisor-remote: prevent lazy-fetch recursion in child fetch Paul Tarjan via GitGitGadget
2026-03-04 17:41 ` Junio C Hamano
2026-03-04 18:20   ` Paul Tarjan [this message]
2026-03-04 18:27 ` [PATCH v2] " Paul Tarjan via GitGitGadget
2026-03-11 10:52   ` Patrick Steinhardt
2026-03-11 14:18     ` Paul Tarjan
2026-03-12  7:27       ` Patrick Steinhardt
2026-03-13  1:43         ` Jeff King
2026-03-13 12:43           ` [PATCH v3] " Paul Tarjan
2026-03-13 12:43         ` Paul Tarjan
2026-04-15 18:05           ` Junio C Hamano
2026-03-11 14:19   ` Paul Tarjan via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260304182057.26463-1-github@paulisageek.com \
    --to=paul@paultarjan.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hanxin.hx@bytedance.com \
    --cc=jeffhostetler@github.com \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.