From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Adamenko <marusik.adamenko@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: core: remove unnecessary goto in usb_create_newid_files()
Date: Wed, 4 Mar 2026 16:48:41 +0100 [thread overview]
Message-ID: <2026030425-animation-doily-912f@gregkh> (raw)
In-Reply-To: <20260304154216.2750-1-marusik.adamenko@gmail.com>
On Wed, Mar 04, 2026 at 07:42:16AM -0800, Mark Adamenko wrote:
> The goto to 'exit' only returns the already initialized variable
> 'error', which would be 0. At that point it could not yet be anything
> else. Replacing with an early return 0 removes the
> need for the label entirely.
>
> Signed-off-by: Mark Adamenko <marusik.adamenko@gmail.com>
> ---
> v2: fix missing return statement at end of function
This is v3 :(
next prev parent reply other threads:[~2026-03-04 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 15:42 [PATCH v2] usb: core: remove unnecessary goto in usb_create_newid_files() Mark Adamenko
2026-03-04 15:48 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-04 6:46 Mark Adamenko
2026-03-04 8:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026030425-animation-doily-912f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marusik.adamenko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.