From: Nithurshen <nithurshen.dev@gmail.com>
To: linux-erofs@lists.ozlabs.org
Cc: xiang@kernel.org, hsiangkao@linux.alibaba.com,
Nithurshen <nithurshen.dev@gmail.com>
Subject: [PATCH] erofs-utils: fix memory leak in z_erofs_qpl_get_job()
Date: Thu, 5 Mar 2026 06:18:35 +0530 [thread overview]
Message-ID: <20260305004835.39574-1-nithurshen.dev@gmail.com> (raw)
If qpl_init_job() fails, the previously allocated job memory
is not freed before returning. Fix this by adding a `free(job)`
call in the error path.
Signed-off-by: Nithurshen <nithurshen.dev@gmail.com>
---
lib/decompress.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/decompress.c b/lib/decompress.c
index 3e7a173..e7ec83e 100644
--- a/lib/decompress.c
+++ b/lib/decompress.c
@@ -149,6 +149,7 @@ static qpl_job *z_erofs_qpl_get_job(void)
status = qpl_init_job(execution_path, (qpl_job *)job->job);
if (status != QPL_STS_OK) {
erofs_err("failed to initialize job: %d", status);
+ free(job);
return ERR_PTR(-EOPNOTSUPP);
}
erofs_atomic_dec_return(&z_erofs_qpl_reclaim_quot);
--
2.51.0
reply other threads:[~2026-03-05 0:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305004835.39574-1-nithurshen.dev@gmail.com \
--to=nithurshen.dev@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.