From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
razor@blackwall.org, pabeni@redhat.com, willemb@google.com,
sdf@fomichev.me, john.fastabend@gmail.com, martin.lau@kernel.org,
jordan@jrife.io, maciej.fijalkowski@intel.com,
magnus.karlsson@intel.com, dw@davidwei.uk, toke@redhat.com,
yangzhenze@bytedance.com, wangdongdong.6@bytedance.com
Subject: Re: [PATCH net-next v8 02/16] net: Implement netdev_nl_queue_create_doit
Date: Thu, 5 Mar 2026 18:10:41 -0800 [thread overview]
Message-ID: <20260305181041.7ed26e4e@kernel.org> (raw)
In-Reply-To: <5065f783-9378-4965-8266-e494cdee46d2@iogearbox.net>
On Thu, 5 Mar 2026 05:38:06 +0100 Daniel Borkmann wrote:
> >> + rxq_lease = __netif_get_rx_queue(dev_lease, queue_id_lease);
> >> + rxq = __netif_get_rx_queue(dev, dev->real_num_rx_queues - 1);
> >> +
> >> + if (rxq->lease && rxq->lease->dev != dev_lease) {
> >
> > IIUC the simplification of having all leases from one devices is still
> > a netkit thing? I mean - there's nothing in the core that depends on
> > this, just the cleanup / notifier handling in netkit? If that's the
> > case let's move this check into netkit.
> >
> > Sorry if you moved this here because I asked to move as much as
> > possible into the core.
> Imho it was a good suggestion to move it here and I would prefer to leave
> this in the core, and only really move it into a per-driver constraint
> once we see a driver wanting to support such setting. Otherwise we would
> propagate AF_XDP support on the device where some queues have support but
> others don't.
Alright, let's add a comment explaining the status and plan then?
next prev parent reply other threads:[~2026-03-06 2:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 22:28 [PATCH net-next v8 00/16] netkit: Support for io_uring zero-copy and AF_XDP Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 01/16] net: Add queue-create operation Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 02/16] net: Implement netdev_nl_queue_create_doit Daniel Borkmann
2026-01-31 23:45 ` Jakub Kicinski
2026-03-05 4:38 ` Daniel Borkmann
2026-03-06 2:10 ` Jakub Kicinski [this message]
2026-03-06 5:49 ` Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 03/16] net: Add lease info to queue-get response Daniel Borkmann
2026-01-31 23:43 ` Jakub Kicinski
2026-02-01 0:15 ` Jakub Kicinski
2026-01-29 22:28 ` [PATCH net-next v8 04/16] net, ethtool: Disallow leased real rxqs to be resized Daniel Borkmann
2026-01-31 23:45 ` Jakub Kicinski
2026-01-29 22:28 ` [PATCH net-next v8 05/16] net: Slightly simplify net_mp_{open,close}_rxq Daniel Borkmann
2026-01-31 23:48 ` Jakub Kicinski
2026-01-29 22:28 ` [PATCH net-next v8 06/16] net: Proxy net_mp_{open,close}_rxq for leased queues Daniel Borkmann
2026-02-01 0:02 ` Jakub Kicinski
2026-02-01 22:09 ` David Wei
2026-01-29 22:28 ` [PATCH net-next v8 07/16] net: Proxy netdev_queue_get_dma_dev " Daniel Borkmann
2026-02-01 0:04 ` Jakub Kicinski
2026-02-01 22:23 ` David Wei
2026-01-29 22:28 ` [PATCH net-next v8 08/16] xsk: Extend xsk_rcv_check validation Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 09/16] xsk: Proxy pool management for leased queues Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 10/16] netkit: Add single device mode for netkit Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 11/16] netkit: Implement rtnl_link_ops->alloc and ndo_queue_create Daniel Borkmann
2026-02-01 0:19 ` Jakub Kicinski
2026-02-01 22:27 ` David Wei
2026-01-29 22:28 ` [PATCH net-next v8 12/16] netkit: Add netkit notifier to check for unregistering devices Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 13/16] netkit: Add xsk support for af_xdp applications Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 14/16] selftests/net: Add bpf skb forwarding program Daniel Borkmann
2026-01-29 22:28 ` [PATCH net-next v8 15/16] selftests/net: Add env for container based tests Daniel Borkmann
2026-02-01 0:38 ` Jakub Kicinski
2026-02-01 22:53 ` David Wei
2026-02-02 18:41 ` Jakub Kicinski
2026-02-10 0:25 ` David Wei
2026-02-05 2:08 ` Bobby Eshleman
2026-02-05 2:34 ` Bobby Eshleman
2026-02-10 17:30 ` David Wei
2026-01-29 22:28 ` [PATCH net-next v8 16/16] selftests/net: Add netkit container tests Daniel Borkmann
2026-02-01 0:24 ` Jakub Kicinski
2026-02-01 22:54 ` David Wei
2026-02-05 1:44 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305181041.7ed26e4e@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=john.fastabend@gmail.com \
--cc=jordan@jrife.io \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=toke@redhat.com \
--cc=wangdongdong.6@bytedance.com \
--cc=willemb@google.com \
--cc=yangzhenze@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.