From: B4 Bugbot <bugbot+b4@kernel.org>
To: miguel.ojeda.sandonis@gmail.com, tools@kernel.org,
konstantin@linuxfoundation.org
Subject: Re: `b4` drops added trailers with peculiar patch
Date: Fri, 6 Mar 2026 19:45:53 +0000 (UTC) [thread overview]
Message-ID: <20260306-b9453f65c3-652300b26533@git.kernel.org> (raw)
In-Reply-To: <CANiq72nLuYfoVnWGjmEmUJDKSpFJq9wUXfTND1e3cjwhe0KFFQ@mail.gmail.com>
Konstantin Ryabitsev writes in commit 6cf7adf5876a65bc019fc91aa5add0d4fd409790:
Allow trailing whitespace in patch separator line
When a patch message contains "--- " (with trailing space) instead
of a clean "---", get_body_parts() failed to split the message
correctly. This caused any follow-up trailers (Reviewed-by, Link,
Signed-off-by, etc.) to be placed after the separator, where git-am
silently discards them.
Change the regex from "^---\n" to "^---\s*\n" so trailing whitespace
on the separator line is tolerated. The rebuild_message() method
always writes a clean "---\n", so the whitespace is cleaned up
automatically.
Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Closes: https://msgid.link/CANiq72nLuYfoVnWGjmEmUJDKSpFJq9wUXfTND1e3cjwhe0KFFQ@mail.gmail.com # 9453f65
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Assisted-by: claude-opus-4-6
--
Deet-doot-dot, I am a bot.
b4 bug tracker (bugspray 0.1-dev)
prev parent reply other threads:[~2026-03-06 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 20:10 `b4` drops added trailers with peculiar patch Miguel Ojeda
2026-03-06 0:58 ` Konstantin Ryabitsev
2026-03-06 1:15 ` Miguel Ojeda
2026-03-06 1:06 ` B4 Bugbot
2026-03-06 19:45 ` B4 Bugbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306-b9453f65c3-652300b26533@git.kernel.org \
--to=bugbot+b4@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.