Re: [PATCH 2/3] iio: adc: ad4130: introduce chip info for future multidevice support

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <b95a029f836a1d2d125f5beccf5290cfcf32c725.1772078999.git.Jonathan.Santos@analog.com>
References: <b95a029f836a1d2d125f5beccf5290cfcf32c725.1772078999.git.Jonathan.Santos@analog.com>
TO: Jonathan Santos <Jonathan.Santos@analog.com>
TO: linux-iio@vger.kernel.org
TO: linux-kernel@vger.kernel.org
TO: devicetree@vger.kernel.org
CC: Jonathan Santos <Jonathan.Santos@analog.com>
CC: cosmin.tanislav@analog.com
CC: lars@metafoo.de
CC: Michael.Hennerich@analog.com
CC: jic23@kernel.org
CC: dlechner@baylibre.com
CC: nuno.sa@analog.com
CC: andy@kernel.org
CC: robh@kernel.org
CC: krzk+dt@kernel.org
CC: conor+dt@kernel.org

Hi Jonathan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v7.0-rc2 next-20260305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jonathan-Santos/dt-bindings-iio-adc-ad4130-Add-new-supported-parts/20260303-002854
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/b95a029f836a1d2d125f5beccf5290cfcf32c725.1772078999.git.Jonathan.Santos%40analog.com
patch subject: [PATCH 2/3] iio: adc: ad4130: introduce chip info for future multidevice support
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: m68k-randconfig-r072-20260305 (https://download.01.org/0day-ci/archive/20260306/202603060334.Qy6YCwgJ-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.3.0
smatch: v0.5.0-9004-gb810ac53

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202603060334.Qy6YCwgJ-lkp@intel.com/

New smatch warnings:
drivers/iio/adc/ad4130.c:1527 ad4130_validate_diff_channel() error: buffer overflow 'st->pins_fn' 16 <= 29

Old smatch warnings:
drivers/iio/adc/ad4130.c:1530 ad4130_validate_diff_channel() error: buffer overflow 'st->pins_fn' 16 <= 29
drivers/iio/adc/ad4130.c:1532 ad4130_validate_diff_channel() error: buffer overflow 'st->pins_fn' 16 <= 29

vim +1527 drivers/iio/adc/ad4130.c

62094060cf3aca Cosmin Tanislav 2022-10-21  1515  
62094060cf3aca Cosmin Tanislav 2022-10-21  1516  static int ad4130_validate_diff_channel(struct ad4130_state *st, u32 pin)
62094060cf3aca Cosmin Tanislav 2022-10-21  1517  {
62094060cf3aca Cosmin Tanislav 2022-10-21  1518  	struct device *dev = &st->spi->dev;
62094060cf3aca Cosmin Tanislav 2022-10-21  1519  
62094060cf3aca Cosmin Tanislav 2022-10-21  1520  	if (pin >= AD4130_MAX_DIFF_INPUTS)
62094060cf3aca Cosmin Tanislav 2022-10-21  1521  		return dev_err_probe(dev, -EINVAL,
6abcb19e0a6a37 Colin Ian King  2022-11-04  1522  				     "Invalid differential channel %u\n", pin);
62094060cf3aca Cosmin Tanislav 2022-10-21  1523  
9244a45dc94161 Jonathan Santos 2026-02-28  1524  	if (pin >= st->chip_info->max_analog_pins)
62094060cf3aca Cosmin Tanislav 2022-10-21  1525  		return 0;
62094060cf3aca Cosmin Tanislav 2022-10-21  1526  
62094060cf3aca Cosmin Tanislav 2022-10-21 @1527  	if (st->pins_fn[pin] == AD4130_PIN_FN_SPECIAL)
62094060cf3aca Cosmin Tanislav 2022-10-21  1528  		return dev_err_probe(dev, -EINVAL,
62094060cf3aca Cosmin Tanislav 2022-10-21  1529  				     "Pin %u already used with fn %u\n", pin,
62094060cf3aca Cosmin Tanislav 2022-10-21  1530  				     st->pins_fn[pin]);
62094060cf3aca Cosmin Tanislav 2022-10-21  1531  
62094060cf3aca Cosmin Tanislav 2022-10-21  1532  	st->pins_fn[pin] |= AD4130_PIN_FN_DIFF;
62094060cf3aca Cosmin Tanislav 2022-10-21  1533  
62094060cf3aca Cosmin Tanislav 2022-10-21  1534  	return 0;
62094060cf3aca Cosmin Tanislav 2022-10-21  1535  }
62094060cf3aca Cosmin Tanislav 2022-10-21  1536  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki