From: kernel test robot <lkp@intel.com>
To: Ivan Lipski <ivan.lipski@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>,
Fangzhi Zuo <jerry.zuo@amd.com>
Subject: drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:1267 mod_freesync_handle_v_update() warn: inconsistent indenting
Date: Fri, 06 Mar 2026 03:57:06 +0800 [thread overview]
Message-ID: <202603060344.yUNMu6hT-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c107785c7e8dbabd1c18301a1c362544b5786282
commit: 33c995709121a3a29d4567a08c943bf7a5b24b78 drm/amd/display: Allow VRR params change if unsynced with the stream
date: 4 months ago
config: alpha-randconfig-r071-20260304 (https://download.01.org/0day-ci/archive/20260306/202603060344.yUNMu6hT-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.2.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603060344.yUNMu6hT-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:1267 mod_freesync_handle_v_update() warn: inconsistent indenting
vim +1267 drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c
1166
1167 void mod_freesync_handle_v_update(struct mod_freesync *mod_freesync,
1168 const struct dc_stream_state *stream,
1169 struct mod_vrr_params *in_out_vrr)
1170 {
1171 struct core_freesync *core_freesync = NULL;
1172 unsigned int cur_timestamp_in_us;
1173 unsigned long long cur_tick;
1174
1175 if ((mod_freesync == NULL) || (stream == NULL) || (in_out_vrr == NULL))
1176 return;
1177
1178 core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync);
1179
1180 if (in_out_vrr->supported == false)
1181 return;
1182
1183 cur_tick = dm_get_timestamp(core_freesync->dc->ctx);
1184 cur_timestamp_in_us = (unsigned int)
1185 div_u64(dm_get_elapse_time_in_ns(core_freesync->dc->ctx, cur_tick, 0), 1000);
1186
1187 in_out_vrr->flip_interval.vsyncs_between_flip++;
1188 in_out_vrr->flip_interval.v_update_timestamp_in_us = cur_timestamp_in_us;
1189
1190 if (in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE &&
1191 (in_out_vrr->flip_interval.flip_interval_workaround_active ||
1192 (!in_out_vrr->flip_interval.flip_interval_workaround_active &&
1193 in_out_vrr->flip_interval.program_flip_interval_workaround))) {
1194 // set freesync vmin vmax to nominal for workaround
1195 in_out_vrr->adjust.v_total_min =
1196 mod_freesync_calc_v_total_from_refresh(
1197 stream, in_out_vrr->max_refresh_in_uhz);
1198 in_out_vrr->adjust.v_total_max =
1199 in_out_vrr->adjust.v_total_min;
1200 in_out_vrr->flip_interval.program_flip_interval_workaround = false;
1201 in_out_vrr->flip_interval.do_flip_interval_workaround_cleanup = true;
1202 return;
1203 }
1204
1205 if (in_out_vrr->state != VRR_STATE_ACTIVE_VARIABLE &&
1206 in_out_vrr->flip_interval.do_flip_interval_workaround_cleanup) {
1207 in_out_vrr->flip_interval.do_flip_interval_workaround_cleanup = false;
1208 in_out_vrr->flip_interval.flip_interval_detect_counter = 0;
1209 in_out_vrr->flip_interval.vsyncs_between_flip = 0;
1210 in_out_vrr->flip_interval.vsync_to_flip_in_us = 0;
1211 }
1212
1213 /* Below the Range Logic */
1214
1215 /* Only execute if in fullscreen mode */
1216 if (in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE &&
1217 in_out_vrr->btr.btr_active) {
1218 /* TODO: pass in flag for Pre-DCE12 ASIC
1219 * in order for frame variable duration to take affect,
1220 * it needs to be done one VSYNC early, which is at
1221 * frameCounter == 1.
1222 * For DCE12 and newer updates to V_TOTAL_MIN/MAX
1223 * will take affect on current frame
1224 */
1225 if (in_out_vrr->btr.frames_to_insert ==
1226 in_out_vrr->btr.frame_counter) {
1227 in_out_vrr->adjust.v_total_min =
1228 calc_v_total_from_duration(stream,
1229 in_out_vrr,
1230 in_out_vrr->btr.inserted_duration_in_us);
1231 in_out_vrr->adjust.v_total_max =
1232 in_out_vrr->adjust.v_total_min;
1233 }
1234
1235 if (in_out_vrr->btr.frame_counter > 0)
1236 in_out_vrr->btr.frame_counter--;
1237
1238 /* Restore FreeSync */
1239 if (in_out_vrr->btr.frame_counter == 0) {
1240 in_out_vrr->adjust.v_total_min =
1241 mod_freesync_calc_v_total_from_refresh(stream,
1242 in_out_vrr->max_refresh_in_uhz);
1243 in_out_vrr->adjust.v_total_max =
1244 mod_freesync_calc_v_total_from_refresh(stream,
1245 in_out_vrr->min_refresh_in_uhz);
1246 }
1247 }
1248
1249 /* If in fullscreen freesync mode or in video, do not program
1250 * static screen ramp values
1251 */
1252 if (in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE)
1253 in_out_vrr->fixed.ramping_active = false;
1254
1255 /* Gradual Static Screen Ramping Logic
1256 * Execute if ramp is active and user enabled freesync static screen
1257 */
1258 if (in_out_vrr->state == VRR_STATE_ACTIVE_FIXED &&
1259 in_out_vrr->fixed.ramping_active) {
1260 update_v_total_for_static_ramp(
1261 core_freesync, stream, in_out_vrr);
1262 }
1263
1264 /*
1265 * If VRR is inactive, set vtotal min and max to nominal vtotal
1266 */
> 1267 if (in_out_vrr->state == VRR_STATE_INACTIVE) {
1268 in_out_vrr->adjust.v_total_min =
1269 mod_freesync_calc_v_total_from_refresh(stream,
1270 in_out_vrr->max_refresh_in_uhz);
1271 in_out_vrr->adjust.v_total_max = in_out_vrr->adjust.v_total_min;
1272 return;
1273 }
1274 }
1275
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-03-05 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 19:57 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-08 5:36 drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:1267 mod_freesync_handle_v_update() warn: inconsistent indenting kernel test robot
2026-03-05 0:56 kernel test robot
2025-11-18 3:24 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603060344.yUNMu6hT-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexander.deucher@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=ivan.lipski@amd.com \
--cc=jerry.zuo@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.