From: Ido Schimmel <idosch@nvidia.com>
To: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Petr Machata <petrm@nvidia.com>, Nir Dotan <nird@mellanox.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: net: forwarding: fix IPv6 address leak in cleanup
Date: Fri, 6 Mar 2026 15:27:32 +0200 [thread overview]
Message-ID: <20260306132732.GA1477080@shredder> (raw)
In-Reply-To: <20260305211000.515301-1-aleksey.oladko@virtuozzo.com>
On Thu, Mar 05, 2026 at 09:10:00PM +0000, Aleksei Oladko wrote:
> Several forwarding tests (e.g., gre_multipath.sh) initialize both IPv4
> and IPv6 addresses using simple_if_init, but only clean up IPv4
> in simple_if_fini. This leaves stale IPv6 addresses on the interfaces,
> which causes subsequent tests to fail when they encounter unexpected
> address configuration.
>
> The issue can be reproduced by running tests in sequence:
> # run_kselftest.sh -t net/forwarding:ipip_hier_gre.sh
> # run_kselftest.sh -t net/forwarding:min_max_mtu.sh
> TAP version 13
> 1..1
> # timeout set to 0
> # selftests: net/forwarding: min_max_mtu.sh
> # TEST: ping [ OK ]
> # TEST: ping6 [ OK ]
> # TEST: Test maximum MTU configuration [ OK ]
> # TEST: Test traffic, packet size is maximum MTU [FAIL]
> # Ping6, packet size: 65487 succeeded, but should have failed
> # TEST: Test minimum MTU configuration [ OK ]
> # TEST: Test traffic, packet size is minimum MTU [ OK ]
> not ok 1 selftests: net/forwarding: min_max_mtu.sh # exit=1
>
> Fix this by removing the unused IPv6 argument from simple_if_init in
> tests that don't use IPv6 (gre_multipath.sh, ipip_lib.sh), and by
> adding the missing IPv6 argument to simple_if_fini in tests that
> use IPv6 (gre_multipath_nh.sh, gre_multipath_nh_res.sh).
>
> Fixes: fed926d4f64c ("selftests: forwarding: Add IP tunneling lib")
> Fixes: 902280cacc03 ("selftests: forwarding: Add resilient multipath tunneling nexthop test")
> Fixes: 54818c4c4b93 ("selftests: forwarding: Test multipath tunneling")
> Fixes: e035146d6560 ("selftests: forwarding: Add multipath tunneling nexthop test")
> Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2026-03-06 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 21:10 [PATCH v2] selftests: net: forwarding: fix IPv6 address leak in cleanup Aleksei Oladko
2026-03-06 13:27 ` Ido Schimmel [this message]
2026-03-07 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306132732.GA1477080@shredder \
--to=idosch@nvidia.com \
--cc=aleksey.oladko@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nird@mellanox.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.