From: Jakub Kicinski <kuba@kernel.org>
To: Jialu Xu <xujialu@vimux.org>
Cc: brgl@kernel.org, kees@kernel.org, krzk@kernel.org,
linusw@kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 1/3] nfc: s3fwrn5: convert to gpio descriptors
Date: Fri, 6 Mar 2026 15:34:46 -0800 [thread overview]
Message-ID: <20260306153446.66ff0357@kernel.org> (raw)
In-Reply-To: <7E5FEA920D0FD172+20260306035909.2447844-3-xujialu@vimux.org>
On Fri, 6 Mar 2026 11:59:09 +0800 Jialu Xu wrote:
> + phy->common.gpio_fw_wake = devm_gpiod_get(&client->dev, "wake",
> + GPIOD_OUT_LOW);
Please make sure continuation line is aligned to after the opening
bracket. There's a few of such issues in this patch.
next prev parent reply other threads:[~2026-03-06 23:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 8:47 [PATCH 0/3] Remove <linux/of_gpio.h> Jialu Xu
2026-03-04 10:52 ` [PATCH v2 " Jialu Xu
2026-03-04 11:07 ` [PATCH v2 1/3] nfc: s3fwrn5: convert to gpio descriptors Jialu Xu
2026-03-05 12:35 ` Linus Walleij
[not found] ` <20260304110740.548318-1-xujialu@vimux.org>
2026-03-04 11:07 ` [PATCH v2 2/3] nfc: nfcmrvl: " Jialu Xu
2026-03-05 12:37 ` Linus Walleij
2026-03-04 11:07 ` [PATCH v2 3/3] gpio: remove of_get_named_gpio() and <linux/of_gpio.h> Jialu Xu
2026-03-05 12:38 ` Linus Walleij
2026-03-06 5:58 ` Jialu Xu
2026-03-05 10:43 ` [PATCH v2 0/3] Remove <linux/of_gpio.h> Bartosz Golaszewski
2026-03-06 1:16 ` Jialu Xu
[not found] ` <20260304105215.536399-1-xujialu@vimux.org>
2026-03-04 10:52 ` [PATCH 1/3] nfc: s3fwrn5: convert to gpio descriptors Jialu Xu
2026-03-04 10:52 ` [PATCH 2/3] nfc: nfcmrvl: " Jialu Xu
2026-03-04 10:52 ` [PATCH 3/3] gpio: remove of_get_named_gpio() and <linux/of_gpio.h> Jialu Xu
2026-03-06 2:00 ` [PATCH v3 0/3] Remove <linux/of_gpio.h> Jialu Xu
2026-03-06 3:53 ` Jialu Xu
2026-03-06 3:59 ` [PATCH v3 1/3] nfc: s3fwrn5: convert to gpio descriptors Jialu Xu
2026-03-06 23:34 ` Jakub Kicinski [this message]
2026-03-06 3:59 ` [PATCH v3 2/3] nfc: nfcmrvl: " Jialu Xu
2026-03-06 23:33 ` [v3,2/3] " Jakub Kicinski
2026-03-06 3:59 ` [PATCH v3 3/3] gpio: remove of_get_named_gpio() and <linux/of_gpio.h> Jialu Xu
2026-03-06 9:38 ` [PATCH v3 0/3] Remove <linux/of_gpio.h> Linus Walleij
2026-03-06 10:25 ` Krzysztof Kozlowski
2026-03-06 13:27 ` Linus Walleij
2026-03-07 2:40 ` Jakub Kicinski
2026-03-07 3:10 ` Jialu Xu
2026-03-07 3:00 ` [PATCH v4 " Jialu Xu
2026-03-07 3:06 ` [PATCH v4 1/3] nfc: s3fwrn5: convert to gpio descriptors Jialu Xu
2026-03-07 3:06 ` [PATCH v4 2/3] nfc: nfcmrvl: " Jialu Xu
2026-03-07 3:06 ` [PATCH v4 3/3] gpio: remove of_get_named_gpio() and <linux/of_gpio.h> Jialu Xu
2026-03-10 9:10 ` [PATCH v4 0/3] Remove <linux/of_gpio.h> Bartosz Golaszewski
2026-03-10 11:38 ` Linus Walleij
2026-03-10 11:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306153446.66ff0357@kernel.org \
--to=kuba@kernel.org \
--cc=brgl@kernel.org \
--cc=kees@kernel.org \
--cc=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xujialu@vimux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.