From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Raju Rangoju <Raju.Rangoju@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] net: xgbe: use device_get_mac_addr
Date: Fri, 6 Mar 2026 16:59:41 -0800 [thread overview]
Message-ID: <20260306165941.525574cc@kernel.org> (raw)
In-Reply-To: <20260304042240.7964-1-rosenp@gmail.com>
On Tue, 3 Mar 2026 20:22:40 -0800 Rosen Penev wrote:
> - ret = device_property_read_u8_array(dev, XGBE_MAC_ADDR_PROPERTY,
> - pdata->mac_addr,
> - sizeof(pdata->mac_addr));
> - if (ret || !is_valid_ether_addr(pdata->mac_addr)) {
> + ret = device_get_mac_address(dev, pdata->mac_addr);
> + if (ret) {
> dev_err(dev, "invalid %s property\n", XGBE_MAC_ADDR_PROPERTY);
Feels a little odd to still use XGBE_MAC_ADDR_PROPERTY in the error
message when now we support any property name for MAC address.
Let's rewrite the error to "invalid MAC address property\n"
and delete XGBE_MAC_ADDR_PROPERTY
--
pw-bot: cr
prev parent reply other threads:[~2026-03-07 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 4:22 [PATCH] net: xgbe: use device_get_mac_addr Rosen Penev
2026-03-07 0:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306165941.525574cc@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.