From: Jakub Kicinski <kuba@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Tobias Waldekranz <tobias@waldekranz.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mdio: mvusb: drop redundant device reference
Date: Fri, 6 Mar 2026 19:19:22 -0800 [thread overview]
Message-ID: <20260306191923.4ae5a6e1@kernel.org> (raw)
In-Reply-To: <20260305104722.16217-1-johan@kernel.org>
On Thu, 5 Mar 2026 11:47:22 +0100 Johan Hovold wrote:
> ret = of_mdiobus_register(mdio, dev->of_node);
> if (ret)
> - goto put_dev;
> + return ret;
>
> return 0;
> -
> -put_dev:
> - usb_put_dev(mvusb->udev);
> - return ret;
better still:
return of_mdiobus_register(mdio, dev->of_node);
and you can remove int ret; as well
next prev parent reply other threads:[~2026-03-07 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 10:47 [PATCH] net: mdio: mvusb: drop redundant device reference Johan Hovold
2026-03-07 3:19 ` Jakub Kicinski [this message]
2026-03-09 8:22 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306191923.4ae5a6e1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.