From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 1/3] mm/damon/core: remove damos_set_next_apply_sis() duplicates
Date: Sat, 7 Mar 2026 11:49:12 -0800 [thread overview]
Message-ID: <20260307194915.203169-2-sj@kernel.org> (raw)
In-Reply-To: <20260307194915.203169-1-sj@kernel.org>
There is a function for damos->next_apply_sis setup. But some places
are open-coding it. Consistently use the helper.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/core.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index e8c44541754f7..c4c30824465ee 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2450,8 +2450,6 @@ static void kdamond_apply_schemes(struct damon_ctx *c)
struct damon_target *t;
struct damon_region *r;
struct damos *s;
- unsigned long sample_interval = c->attrs.sample_interval ?
- c->attrs.sample_interval : 1;
bool has_schemes_to_apply = false;
damon_for_each_scheme(s, c) {
@@ -2482,9 +2480,7 @@ static void kdamond_apply_schemes(struct damon_ctx *c)
if (c->passed_sample_intervals < s->next_apply_sis)
continue;
damos_walk_complete(c, s);
- s->next_apply_sis = c->passed_sample_intervals +
- (s->apply_interval_us ? s->apply_interval_us :
- c->attrs.aggr_interval) / sample_interval;
+ damos_set_next_apply_sis(s, c);
s->last_applied = NULL;
damos_trace_stat(c, s);
}
@@ -2858,7 +2854,6 @@ static void kdamond_init_ctx(struct damon_ctx *ctx)
{
unsigned long sample_interval = ctx->attrs.sample_interval ?
ctx->attrs.sample_interval : 1;
- unsigned long apply_interval;
struct damos *scheme;
ctx->passed_sample_intervals = 0;
@@ -2869,9 +2864,7 @@ static void kdamond_init_ctx(struct damon_ctx *ctx)
ctx->attrs.intervals_goal.aggrs;
damon_for_each_scheme(scheme, ctx) {
- apply_interval = scheme->apply_interval_us ?
- scheme->apply_interval_us : ctx->attrs.aggr_interval;
- scheme->next_apply_sis = apply_interval / sample_interval;
+ damos_set_next_apply_sis(scheme, ctx);
damos_set_filters_default_reject(scheme);
}
}
--
2.47.3
next prev parent reply other threads:[~2026-03-07 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 19:49 [PATCH 0/3] mm/damon/core: make passed_sample_intervals comparisons overflow-safe SeongJae Park
2026-03-07 19:49 ` SeongJae Park [this message]
2026-03-07 19:49 ` [PATCH 2/3] mm/damon/core: use time_before() for next_apply_sis SeongJae Park
2026-03-07 19:49 ` [PATCH 3/3] mm/damon/core: use time_after_eq() in kdamond_fn() SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307194915.203169-2-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.