All of lore.kernel.org
 help / color / mirror / Atom feed
From: deller@kernel.org
To: qemu-devel@nongnu.org
Cc: "Kyle Evans" <kevans@freebsd.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Warner Losh" <imp@bsdimp.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	deller@gmx.de, "Richard Henderson" <richard.henderson@linaro.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: [PULL 06/12] linux-user: fix matching ioctl numbers in print_ioctl
Date: Sun,  8 Mar 2026 18:29:30 +0100	[thread overview]
Message-ID: <20260308172936.2835-7-deller@kernel.org> (raw)
In-Reply-To: <20260308172936.2835-1-deller@kernel.org>

From: Andreas Schwab <schwab@suse.de>

target_cmd in struct IOCTLEntry is a signed int.  Make sure the ioctl cmd
argument in the syscall is converted to int when matching, so that it
works correctly with an ioctl cmd that has bit 31 set.

Signed-off-by: Andreas Schwab <schwab@suse.de>
Reviewed-by: Helge Deller <deller@gmx.de>
Signed-off-by: Helge Deller <deller@gmx.de>
---
 linux-user/strace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 02d610a7f8..2cbaf94c89 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -1021,12 +1021,12 @@ print_syscall_ret_ioctl(CPUArchState *cpu_env, const struct syscallname *name,
         int target_size;
 
         for (ie = ioctl_entries; ie->target_cmd != 0; ie++) {
-            if (ie->target_cmd == arg1) {
+            if (ie->target_cmd == (int)arg1) {
                 break;
             }
         }
 
-        if (ie->target_cmd == arg1 &&
+        if (ie->target_cmd == (int)arg1 &&
            (ie->access == IOC_R || ie->access == IOC_RW)) {
             arg_type = ie->arg_type;
             qemu_log(" (");
@@ -4359,7 +4359,7 @@ print_ioctl(CPUArchState *cpu_env, const struct syscallname *name,
     int target_size;
 
     for (ie = ioctl_entries; ie->target_cmd != 0; ie++) {
-        if (ie->target_cmd == arg1) {
+        if (ie->target_cmd == (int)arg1) {
             break;
         }
     }
-- 
2.53.0



  parent reply	other threads:[~2026-03-08 17:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 17:29 [PULL 00/12] For next patches deller
2026-03-08 17:29 ` [PULL 01/12] hw/hppa: Avoid leaking a diva-gsp device deller
2026-03-08 17:29 ` [PULL 02/12] hw/char: Drop disable property of Diva GSP card deller
2026-03-08 17:29 ` [PULL 03/12] linux-user/strace: fix printing of file offsets deller
2026-03-08 17:29 ` [PULL 04/12] linux-user: properly check flags in openat2 deller
2026-03-08 17:29 ` [PULL 05/12] linux-user: Check if RESOLVE_CACHED flag is defined before using it deller
2026-03-08 17:29 ` deller [this message]
2026-03-08 17:29 ` [PULL 07/12] linux-user: fix TIOCGSID ioctl deller
2026-03-08 17:29 ` [PULL 08/12] linux-user: Deal with mmap where start > reserved_va deller
2026-03-08 17:29 ` [PULL 09/12] bsd-user: " deller
2026-03-08 17:29 ` [PULL 10/12] tests/tcg/multiarch/test-mmap: Print more details deller
2026-03-08 17:29 ` [PULL 11/12] tests/tcg/multiarch/test-mmap: Check mmaps beyond reserved_va deller
2026-03-08 17:29 ` [PULL 12/12] linux-user: Improve formatting for mremap() deller
2026-03-09 13:44 ` [PULL 00/12] For next patches Helge Deller
2026-03-09 13:51   ` Philippe Mathieu-Daudé
2026-03-09 13:53     ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260308172936.2835-7-deller@kernel.org \
    --to=deller@kernel.org \
    --cc=alex.bennee@linaro.org \
    --cc=deller@gmx.de \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.