From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96C9E392807 for ; Sun, 8 Mar 2026 18:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772993096; cv=none; b=WHe7stPxw1gJTGy1DcUddHac1cpB/FSiA5eOuqowIERYFJXOEgGtAJla3uznrWOVXhIVew5eCegyVUaZ0T4ZFvxMCQYWUKN9C17Fw4kXWbnB4r5IA5cTAn4Ywm+GjB/lzC9DCs4wvgFDCeBw07ZHy2OKxCVRp2iw3B/4s/wV5sU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772993096; c=relaxed/simple; bh=AgX6gotevtwS4CzDuXLJlCc/EtBmgVH2SpI1A1QVyKU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qB9jhr12P2ZkFNuigUa9lHs2P69ECVpOyvZg+jKWaUSIvoH8xwQvW2EF9ufvzyMzwe7xFYehaxItjQ2kockg1sX3mXyPNQpug9ok0s5Q6PmYvdaIfuicllhC/C9YMo8TPm093v312+eOBPoWBQcbJh50fYSGJIm4LEYDT5i+guU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JitxkEV+; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JitxkEV+" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8cd767d2d70so137267285a.3 for ; Sun, 08 Mar 2026 11:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772993094; x=1773597894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FN7PvS4hSNNfjqdxRxT29O3AmC62u2I0HRtYDHsUvY0=; b=JitxkEV+0CZ58wKD+G4nvzEE68TbcOJP8NQPHjpae/0TIoBiohZYYNpD+0SX0/P++M HdtMAukSBInOpqIuf7+9jObS95cypFuRZfzjTAHw3/cvFgzwSr1sWeJKlfbzU8mphfUm ETkMUJuEujyf07hM8JVQWud2MlIM9kToJ7fDMHbNwimYTfYqo9mkd4HMjTOqSZoYflUK +YAveBQAnDq0PUu9F3yoYg7oN1U4UF3gRvsRL3aKrcJHF+GgusOHJwol4ekWFlhUND2y HR7bdXy5K6GpATXJ14QAqEpVFxnrwbs5AS64ktx3hYco9HI52T/Fdk+e+rFe72/xSu0T hvqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772993094; x=1773597894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FN7PvS4hSNNfjqdxRxT29O3AmC62u2I0HRtYDHsUvY0=; b=wy1axJnhgUg65FmqdyC+ejZpQXMkcRXL+sDdystVSob6QxAOXW7f5M/+HzUlRrUoas GKGT7tLWZ7XWiqhmelC3INlkCY0CkYoHtnGCZ30zmfwvBKGhgeG+Ka776HWyOi+N5vWs cy8pPBA4gqhlUYHfpf+QBw9oCIaP7TYp4p40Wj580qcceCWOtUPkGgISqmHE3EYLbJEf 0ESWG/vOUu2JTIGuF47cYAXbEODZiwpFbHuPZtuQtMskHROTO/FBhFlz70oovgZdAtid qbzWW0ItXKSmPexPlp6WBbDYlWdg9oB2lBIp6dUI+k4XRYCSoW9y7TwDNkUCXv+fYG5Q pdew== X-Gm-Message-State: AOJu0Yz2QUJckQmM29I37ahfa0q4z/5Nm8v5L3gWC0BPA4R42608JN3R BvtJIQr/JV6cShim+ykTmLEWkTfWskLrpI4+NCVDCfXN48jjbFf6/wcTTByAyldIHFk= X-Gm-Gg: ATEYQzw00KBjYGn5BTKz3zqKPYV4A/sZj7MtllEt27N6F+yS044Y204iSbUw1+jLIRW OpsZfT7iusrUfsMFboXvN/YWGSJs2ZYBildLMoeTLGneukLTx343xzda6TdtG79UMv+RFi27GLo glTlcPwQ8OC59M7MaOLbkcKZrWoHDzJ5rfODHj5bSC18UKPwm/LBZnCWDm9iv0gax+1qZ1h4PEj 1HYCw8hWDFG0NVXZtI9w0bGTzXZaCV/dn0J/fe1uGqXYs8ZBjf1gCS1DAJAt5xFiJZ6Mi6I6wcA sqrbRdTeOCrqIIDQAizMMJL1xMzmWEweFwqdY0cJ6JqfZeSvU5Kgv3SQVXDVqcQ8PAHYDWE4UvY i8t3vg0rJqcH8I42YiVmcTgVqFSHy1wlPNukSm7280G/h4CELIXnaZCXj1K4ZjyYLJzBEdkT66/ sQRuTpyUkjO7ZMIUwbNuU6Eetd/zei0Nu98zTDShnjLqHd0kNnv92/rn8Zrlp4dgdpXobg5xxvc k3v X-Received: by 2002:a05:620a:470d:b0:8cb:e00:8c0d with SMTP id af79cd13be357-8cd6d4a701cmr1105181385a.74.1772993094352; Sun, 08 Mar 2026 11:04:54 -0700 (PDT) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cd8c2d7e69sm4164785a.14.2026.03.08.11.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 11:04:54 -0700 (PDT) From: Josh Law X-Google-Original-From: Josh Law To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH 1/2] lib/ts_bm: fix integer overflow in pattern length calculation Date: Sun, 8 Mar 2026 18:04:52 +0000 Message-ID: <20260308180453.2883890-1-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ts_bm algorithm computes the required allocation size by multiplying the pattern length by the size of an integer. If the pattern length is sufficiently large, this can overflow the 32-bit unsigned int before it is widened to size_t. This could result in an undersized allocation and a subsequent heap buffer overflow when copying the pattern. Fix this by explicitly checking that the length does not exceed the maximum safe threshold before calculating the buffer sizes. Signed-off-by: Josh Law --- lib/ts_bm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/ts_bm.c b/lib/ts_bm.c index eed5967238c5..01ea0a93cf6e 100644 --- a/lib/ts_bm.c +++ b/lib/ts_bm.c @@ -166,6 +166,9 @@ static struct ts_config *bm_init(const void *pattern, unsigned int len, unsigned int prefix_tbl_len = len * sizeof(unsigned int); size_t priv_size = sizeof(*bm) + len + prefix_tbl_len; + if (unlikely(len == 0 || len > (UINT_MAX - sizeof(*bm)) / (sizeof(unsigned int) + 1))) + return ERR_PTR(-EINVAL); + conf = alloc_ts_config(priv_size, gfp_mask); if (IS_ERR(conf)) return conf; -- 2.43.0