From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B36FD39449B for ; Sun, 8 Mar 2026 18:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772993458; cv=none; b=dUWc208yie0s13RYRqr/6UOjUluAUmo5wf85X6LSeC2qOBDpUbEC1PAi3wcL5dbFhqnZlyoaXTpNqT8LsiGjVsf4H/S6120JhCorHvfF9KU1ZzYgHp8GXN1Rp3AIPOGJoJQ6forULSwDvS+YTHKFSY8XekEX7AHe3jaLTklhhmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772993458; c=relaxed/simple; bh=+BBGXQW2g3D9oP975uqst3WKj40em7VRLEczXfVi6e8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FGzbSPGlVTRdWBuKkU1TXx0Vf3xpgQZe0LdgPBe+oem/VzmH53NH3yIwZFV6+axUNozUjR70Y+Upf1oafKljl4krqSlvyXyWsZP8SA27HmFWCd1zoYqgeiV6L6SM2F5QSNENv669HyNBXX+hx3ETmwrua1anZIwHXiqR+cPkNk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mWV5x67f; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mWV5x67f" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-899a9f445cbso133952336d6.0 for ; Sun, 08 Mar 2026 11:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772993456; x=1773598256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dFLT/SgQDF3a4IIuFA5fvgfLPBQlLCQywkugcWC4JtI=; b=mWV5x67fAAquzHyiOhBnxgSJ5vDTpyQ56SHa8Fp/IjRnQhLR4XTjJWKTciLnERTduz hz9Hr/SN8K3tin8Xu0zb1ydxRS85bFDwyKQ8LmQXeZxf8mfed7trwFauB5qkbIJXvgOn SKsKZpDi6by+0sRQsSQYjad76ViwYSK6H/HeYYlX0HPgrM8TmJPCfIpurtmwiek57z+e mB9vNKxf2hLsdwlBX9NTKEB6M4W/jsyT2TvRZaPyhI8Zi5y+4GwUgFyqGe9m1mF5zmCf /p3CHsFYO4PUaswU2rKm/DD/WVDlCI98cfqQz4IgaawW8w9FpSm0S1WAsfBh9DMq8fGu g0dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772993456; x=1773598256; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dFLT/SgQDF3a4IIuFA5fvgfLPBQlLCQywkugcWC4JtI=; b=tSVMmE9xLUfQ+r44l7Ocy+ovTydgpSJVr29ZdNAsgJsZbmPtsELep9WsAlQ81LU7LW oaoLV48rRmbBzSRerAXfAFE9kHKmjSj1LxKtagUOKQBQe+14er26P9K+y8ENLXFgctXE wbT3yThAV3VUWSy7Ck/A/4rjzVBDYtkBr82FY9cKbCfJoFT6q8tqmRBIoPIlp6F9Eiy+ sS3VydJaAqUT9+fJH540wdrkoD+6QVYLTqSSqfdrEKlxjKPkYGzn7W+K70KsSvCQ4pMZ Jfn90QCPs0xCeJuOUGUUv95cHCKo5UC8uSyfyHAb+hDT5ezPWg3UN9i2rot/fIolPl2i jMow== X-Gm-Message-State: AOJu0Yy5uAlUarBQEG6k1m431RRqpRFafpgMRie7CZiMQO0y20WGm4RO rOp0JTV1TSBSLFP+ciazP4WKrQfKxbDFnQfTf/qAFyXfMUymqXxfMCvV6SyrxqOUKEI= X-Gm-Gg: ATEYQzz1aRRAOHMJQ8A5WSEMcaPXO97btXnXGmC0NqFty8d+mJuS33WkAwsLfIRU2IN gHMzIZhreN7HMH1RERbbfk/18J89CU2gv5TaIPcx22K5kfk/OabhYgCeGR0t3d/4n1CmBCldo29 H8EgpP1Q2i71JOc0K7rQDRGFRargoIk/9T41aldTXJjhfT++GpIQFUbuxtRVa4FuOFoiBqLDUZu dv6d5zoQsJ33aIooaNSzEDsUOmbtKbS0yUTST+zZWrd5+PwSD8Kkh1LyeB4B9Lpudx2h3GSKPR+ BcZ7wSDNBH6Q9J+DKtNPioVIrK7Gm6zVna/MYb2LAg36jzR0+yWX3Q/6+MRwx5KDpyRZjUskwX9 tqtpwRrjTTtp2nYjtndzMDC9qk4AAzooxO1oHSK2/bouVpiwa1cKGDrX64AY2Y+3Zcjc9kVMjGX oeUsyaGWF2kav+jvmO/lRcwtHkFMwthLT40fkn/7I4bOE6j57DF3t+T2BQtCUVBfq+G2YvS6Kar 5Wu X-Received: by 2002:a05:6214:29c3:b0:89a:83a:2148 with SMTP id 6a1803df08f44-89a30c28fcamr138596626d6.63.1772993456588; Sun, 08 Mar 2026 11:10:56 -0700 (PDT) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a314645fcsm56199166d6.22.2026.03.08.11.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2026 11:10:56 -0700 (PDT) From: Josh Law X-Google-Original-From: Josh Law To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v2 1/2] lib/ts_bm: fix integer overflow in pattern length calculation Date: Sun, 8 Mar 2026 18:10:53 +0000 Message-ID: <20260308181054.2884026-1-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Josh Law The ts_bm algorithm computes the required allocation size by multiplying the pattern length by the size of an integer. If the pattern length is sufficiently large, this can overflow the 32-bit unsigned int before it is widened to size_t. This could result in an undersized allocation and a subsequent heap buffer overflow when copying the pattern. Fix this by explicitly checking that the length does not exceed the maximum safe threshold before calculating the buffer sizes. Signed-off-by: Josh Law --- lib/ts_bm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/ts_bm.c b/lib/ts_bm.c index eed5967238c5..01ea0a93cf6e 100644 --- a/lib/ts_bm.c +++ b/lib/ts_bm.c @@ -166,6 +166,9 @@ static struct ts_config *bm_init(const void *pattern, unsigned int len, unsigned int prefix_tbl_len = len * sizeof(unsigned int); size_t priv_size = sizeof(*bm) + len + prefix_tbl_len; + if (unlikely(len == 0 || len > (UINT_MAX - sizeof(*bm)) / (sizeof(unsigned int) + 1))) + return ERR_PTR(-EINVAL); + conf = alloc_ts_config(priv_size, gfp_mask); if (IS_ERR(conf)) return conf; -- 2.43.0