Re: [PATCH RFC v5 2/4] clk: test: introduce test suite for sibling rate changes on a divider

[kernel test robot <lkp@intel.com>]

Hi Brian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on fc7b1a72c6cd5cbbd989c6c32a6486e3e4e3594d]

url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-test-introduce-clk_dummy_div-for-a-mock-divider/20260307-074328
base:   fc7b1a72c6cd5cbbd989c6c32a6486e3e4e3594d
patch link:    https://lore.kernel.org/r/20260306-clk-scaling-v5-2-d21b84ee6f27%40redhat.com
patch subject: [PATCH RFC v5 2/4] clk: test: introduce test suite for sibling rate changes on a divider
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260308/202603082228.3RYA8l9q-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260308/202603082228.3RYA8l9q-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603082228.3RYA8l9q-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/clk/clk_test.c:686:26: error: use of undeclared identifier 'HZ_PER_MHZ'
     686 |         ctx->parent.rate = 24 * HZ_PER_MHZ;
         |                                 ^
   drivers/clk/clk_test.c:709:60: error: use of undeclared identifier 'HZ_PER_MHZ'
     709 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->parent_clk), 24 * HZ_PER_MHZ);
         |                                                                   ^
   drivers/clk/clk_test.c:709:60: error: use of undeclared identifier 'HZ_PER_MHZ'
   drivers/clk/clk_test.c:710:60: error: use of undeclared identifier 'HZ_PER_MHZ'
     710 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child1_clk), 24 * HZ_PER_MHZ);
         |                                                                   ^
   drivers/clk/clk_test.c:710:60: error: use of undeclared identifier 'HZ_PER_MHZ'
   drivers/clk/clk_test.c:711:60: error: use of undeclared identifier 'HZ_PER_MHZ'
     711 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ);
         |                                                                   ^
   drivers/clk/clk_test.c:711:60: error: use of undeclared identifier 'HZ_PER_MHZ'
   drivers/clk/clk_test.c:735:42: error: use of undeclared identifier 'HZ_PER_MHZ'
     735 |         ret = clk_set_rate(ctx->child1_clk, 6 * HZ_PER_MHZ);
         |                                                 ^
   drivers/clk/clk_test.c:738:60: error: use of undeclared identifier 'HZ_PER_MHZ'
     738 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->parent_clk), 24 * HZ_PER_MHZ);
         |                                                                   ^
   drivers/clk/clk_test.c:738:60: error: use of undeclared identifier 'HZ_PER_MHZ'
   drivers/clk/clk_test.c:739:59: error: use of undeclared identifier 'HZ_PER_MHZ'
     739 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child1_clk), 6 * HZ_PER_MHZ);
         |                                                                  ^
   drivers/clk/clk_test.c:739:59: error: use of undeclared identifier 'HZ_PER_MHZ'
   drivers/clk/clk_test.c:741:60: error: use of undeclared identifier 'HZ_PER_MHZ'
     741 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ);
         |                                                                   ^
   drivers/clk/clk_test.c:741:60: error: use of undeclared identifier 'HZ_PER_MHZ'
   drivers/clk/clk_test.c:756:43: error: use of undeclared identifier 'HZ_PER_MHZ'
     756 |         ret = clk_set_rate(ctx->child1_clk, 48 * HZ_PER_MHZ);
         |                                                  ^
   drivers/clk/clk_test.c:759:60: error: use of undeclared identifier 'HZ_PER_MHZ'
     759 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->parent_clk), 48 * HZ_PER_MHZ);
         |                                                                   ^
   drivers/clk/clk_test.c:759:60: error: use of undeclared identifier 'HZ_PER_MHZ'
   drivers/clk/clk_test.c:760:60: error: use of undeclared identifier 'HZ_PER_MHZ'
     760 |         KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child1_clk), 48 * HZ_PER_MHZ);
         |                                                                   ^
   drivers/clk/clk_test.c:760:60: error: use of undeclared identifier 'HZ_PER_MHZ'
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.


vim +/HZ_PER_MHZ +686 drivers/clk/clk_test.c

   670	
   671	KUNIT_ARRAY_PARAM_DESC(clk_rate_change_sibling_div_div_test_regular_ops,
   672			       clk_rate_change_sibling_div_div_test_regular_ops_params, desc)
   673	
   674	static int clk_rate_change_sibling_div_div_test_init(struct kunit *test)
   675	{
   676		const struct clk_rate_change_sibling_div_div_test_param *param = test->param_value;
   677		struct clk_rate_change_sibling_div_div_context *ctx;
   678		int ret;
   679	
   680		ctx = kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL);
   681		if (!ctx)
   682			return -ENOMEM;
   683		test->priv = ctx;
   684	
   685		ctx->parent.hw.init = CLK_HW_INIT_NO_PARENT("parent", &clk_dummy_rate_ops, 0);
 > 686		ctx->parent.rate = 24 * HZ_PER_MHZ;
   687		ret = clk_hw_register_kunit(test, NULL, &ctx->parent.hw);
   688		if (ret)
   689			return ret;
   690	
   691		ctx->child1.hw.init = CLK_HW_INIT_HW("child1", &ctx->parent.hw,
   692						     param->ops, CLK_SET_RATE_PARENT);
   693		ctx->child1.div = 1;
   694		ret = clk_hw_register_kunit(test, NULL, &ctx->child1.hw);
   695		if (ret)
   696			return ret;
   697	
   698		ctx->child2.hw.init = CLK_HW_INIT_HW("child2", &ctx->parent.hw,
   699						     param->ops, CLK_SET_RATE_PARENT);
   700		ctx->child2.div = 1;
   701		ret = clk_hw_register_kunit(test, NULL, &ctx->child2.hw);
   702		if (ret)
   703			return ret;
   704	
   705		ctx->parent_clk = clk_hw_get_clk(&ctx->parent.hw, NULL);
   706		ctx->child1_clk = clk_hw_get_clk(&ctx->child1.hw, NULL);
   707		ctx->child2_clk = clk_hw_get_clk(&ctx->child2.hw, NULL);
   708	
   709		KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->parent_clk), 24 * HZ_PER_MHZ);
   710		KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child1_clk), 24 * HZ_PER_MHZ);
   711		KUNIT_EXPECT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ);
   712	
   713		return 0;
   714	}
   715	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki