From: Qingfang Deng <dqfext@gmail.com>
To: David Sterba <dsterba@suse.cz>
Cc: Jiri Slaby <jirislaby@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
duoming@zju.edu.cn, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, dsterba@suse.com, kuba@kernel.org,
alexander.deucher@amd.com, akpm@linux-foundation.org,
pkshih@realtek.com, tglx@kernel.org, mingo@kernel.org
Subject: Re: [PATCH] tty: ipwireless: Fix use-after-free in tasklet during device removal
Date: Mon, 9 Mar 2026 19:18:18 +0800 [thread overview]
Message-ID: <20260309111827.550-1-dqfext@gmail.com> (raw)
In-Reply-To: <20260218152330.GI26902@suse.cz>
Hi, David
On Wed, 18 Feb 2026 16:23:30 +0100, David Sterba wrote:
> On Tue, Feb 17, 2026 at 09:03:25AM +0100, Jiri Slaby wrote:
> > Hi,
> >
> > On 09. 02. 26, 11:21, David Sterba wrote:
> > > On Sun, Feb 08, 2026 at 06:25:38PM +0100, Jiri Kosina wrote:
> > >> On Sun, 8 Feb 2026, Greg KH wrote:
> > >>
> > >>>> I don't have the real hardware. In order to reproduce the bug, I simulate
> > >>>> the IPWireless PCMCIA card in the qemu by allocating and configuring the
> > >>>> necessary resources(I/O ports, memory regions, interrupts and so on) to
> > >>>> correspond with the hardware expected by the driver in the initialization
> > >>>> code of the virtual device.
> > >>>
> > >>> I wonder if this device even is still around, given that pcmcia is all
> > >>> but dead for a very long time.
> > >>
> > >> I doubt that this device is still around anywhere where reasonably new
> > >> kernels (including LTS) would matter.
> > >>
> > >> I don't think I've seen this device (which was back then donated to me by
> > >> T-Mobile CZ in order to get it supported in Linux, and I am not sure how
> > >> much global adoption it got afterwards) for, let's say, past 15 years :)
> > >>
> > >> I think (let's see what David, ho took the maintainership over for me
> > >> afterwards, has to say) we'd better deprecate and drop the whole thing,
> > >> rather than trying to pretend that it's still actively being taken care
> > >> of.
> > >
> > > https://lore.kernel.org/all/20230223172403.GW10580@suse.cz/ last time
> > > the question of keeping the driver was asked (2023). Back then I was
> > > able to find the cards on second hand market but now I can't on a local
> > > market and there's exactly one hit on global eBay.
> > >
> > > Local linux related or telco support forums seem to mention the driver
> > > until 2011 (root.cz, abclinuxu.cz, t-mobile.cz). It does not prove
> > > nobody is using it but I think the chances are quite low to justify
> > > keeping the driver. It is simple enough to be built as an external
> > > module eventually, I can help with that in case somebody really needs
> > > that.
> >
> > So, would you want to submit the removal? Or anyone else, if you don't
> > want to lose time with this? (I can do that, if noone wants to.)
>
> Let me do it after rc1 so I can finish the journey of this driver which
> was my first nontrivial contribution to linux kernel.
I found a memory leak in the driver:
- https://lore.kernel.org/linux-serial/20260306034058.386747-1-dqfext@gmail.com/T/
The bug has been present since the first version of this driver, but it
seems no one has noticed it until now. So I believe the driver has not
been actively used.
Regards,
Qingfang
next prev parent reply other threads:[~2026-03-09 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 6:25 [PATCH] tty: ipwireless: Fix use-after-free in tasklet during device removal Duoming Zhou
2026-02-08 6:38 ` Greg KH
2026-02-08 10:28 ` duoming
2026-02-08 11:00 ` Greg KH
2026-02-08 13:57 ` duoming
2026-02-08 14:34 ` Greg KH
2026-02-08 14:53 ` duoming
2026-02-08 14:58 ` Greg KH
2026-02-08 17:25 ` Jiri Kosina
2026-02-09 10:21 ` David Sterba
2026-02-17 8:03 ` Jiri Slaby
2026-02-18 15:23 ` David Sterba
2026-03-09 11:18 ` Qingfang Deng [this message]
2026-03-09 11:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309111827.550-1-dqfext@gmail.com \
--to=dqfext@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=duoming@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pkshih@realtek.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.