From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E7D7EFCD95 for ; Mon, 9 Mar 2026 10:44:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A50910E4CE; Mon, 9 Mar 2026 10:44:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="TYefRWqY"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7254410E4CE for ; Mon, 9 Mar 2026 10:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773053053; bh=eV84bk9FhFfN7BpVXp3SXNhSp+EovBeQ7FCK5NofEi0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TYefRWqYPaZbauooGDUdvpnjdc6FHbce0Zv/3P6sE1stb8rc+iiuStIzFYByYQDt0 hcpGRPKGLk6dJoYzHu85cH2I44Hu1pjeNW8sYH4MGh+2F7U+KGGqsLZKHHo4S5gnoX R5a6wnEHpn97vcaZucUlNcdxXrs3M6ccGOVRABLftx/vH2X2QMWtqzytMnWVW4hSrC JU40+9SQ721xg/62Uv1cK7ESK5p10hfNEhSw5V9V99fEr+lr7Q4dOdSAEJzrByOSCO QGXcf4Mx+3cm28VKYRrfRV3hQu7wvXTJ3x1HrRiQg5e6C1p+NLN4/Nvv5FxwCwPOCl gDn2lJHnZTwWg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 555CA17E0DC0; Mon, 9 Mar 2026 11:44:12 +0100 (CET) Date: Mon, 9 Mar 2026 11:44:07 +0100 From: Boris Brezillon To: Steven Price Cc: Liviu Dudau , =?UTF-8?B?QWRyacOhbg==?= Larumbe , dri-devel@lists.freedesktop.org, David Airlie , Simona Vetter , Akash Goel , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Osipenko , Chris Diamand , Danilo Krummrich , Matthew Brost , Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?= , Alice Ryhl , Chia-I Wu , kernel@collabora.com Subject: Re: [PATCH v4 9/9] drm/panthor: Add a GEM shrinker Message-ID: <20260309114407.45d6a8e3@fedora> In-Reply-To: <0fbe7ff5-62e4-4345-882b-ca27195aa510@arm.com> References: <20260305124320.156606-1-boris.brezillon@collabora.com> <20260305124320.156606-10-boris.brezillon@collabora.com> <0fbe7ff5-62e4-4345-882b-ca27195aa510@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 6 Mar 2026 15:17:25 +0000 Steven Price wrote: > > +int panthor_vm_evict_bo_mappings_locked(struct panthor_gem_object *bo) > > +{ > > + struct drm_gpuvm_bo *vm_bo; > > + > > + drm_gem_for_each_gpuvm_bo(vm_bo, &bo->base) { > > + struct panthor_vm *vm = container_of(vm_bo->vm, struct panthor_vm, base); > > + struct drm_gpuva *va; > > + > > + /* Skip already evicted GPU mappings. */ > > + if (vm_bo->evicted) > > + continue; > > + > > + if (!mutex_trylock(&vm->op_lock)) > > + return -EDEADLK; > > + > > + drm_gpuvm_bo_evict(vm_bo, true); > > + drm_gpuvm_bo_for_each_va(va, vm_bo) { > > + struct panthor_vma *vma = container_of(va, struct panthor_vma, base); > > + > > + if (vma->evicted) > > + continue; > > + > > + panthor_vm_lock_region(vm, va->va.addr, va->va.range); > > NIT: You are ignoring the return value here - it might be better to bail > out instead if this happens. Will do in v5. > Admittedly this is a "should never happen" case. Better safe than sorry.