Re: [RFC net-next v2 5/6] netdevsim: Add module EEPROM simulation via debugfs

[kernel test robot <lkp@intel.com>]

Hi Björn,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 0bcac7b11262557c990da1ac564d45777eb6b005]

url:    https://github.com/intel-lab-lkp/linux/commits/Bj-rn-T-pel/ethtool-Add-loopback-netlink-UAPI-definitions/20260308-204636
base:   0bcac7b11262557c990da1ac564d45777eb6b005
patch link:    https://lore.kernel.org/r/20260308124016.3134012-6-bjorn%40kernel.org
patch subject: [RFC net-next v2 5/6] netdevsim: Add module EEPROM simulation via debugfs
config: i386-buildonly-randconfig-006-20260309 (https://download.01.org/0day-ci/archive/20260309/202603091145.XesQOgpn-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260309/202603091145.XesQOgpn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603091145.XesQOgpn-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/netdevsim/ethtool.c:212:11: warning: result of comparison of constant 256 with expression of type 'u8' (aka 'unsigned char') is always false [-Wtautological-constant-out-of-range-compare]
     212 |         if (page >= NSIM_MODULE_EEPROM_PAGES)
         |             ~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +212 drivers/net/netdevsim/ethtool.c

   197	
   198	static u8 *nsim_module_eeprom_ptr(struct netdevsim *ns,
   199					  const struct ethtool_module_eeprom *page_data, u32 *len)
   200	{
   201		u32 offset;
   202		u8 page;
   203	
   204		if (page_data->offset < NSIM_MODULE_EEPROM_PAGE_LEN) {
   205			page = 0;
   206			offset = page_data->offset;
   207		} else {
   208			page = page_data->page;
   209			offset = page_data->offset - NSIM_MODULE_EEPROM_PAGE_LEN;
   210		}
   211	
 > 212		if (page >= NSIM_MODULE_EEPROM_PAGES)
   213			return NULL;
   214	
   215		*len = min_t(u32, page_data->length, NSIM_MODULE_EEPROM_PAGE_LEN - offset);
   216		return ns->ethtool.module.pages[page] + offset;
   217	}
   218	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki