From: Hanna Czenczek <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Brian Song <hibriansong@gmail.com>
Subject: [PATCH v5 16/25] fuse: Drop permission changes in fuse_do_truncate
Date: Mon, 9 Mar 2026 16:08:47 +0100 [thread overview]
Message-ID: <20260309150856.26800-17-hreitz@redhat.com> (raw)
In-Reply-To: <20260309150856.26800-1-hreitz@redhat.com>
This function is always called with writable == true. This makes
add_resize_perm always false, and thus we can drop the quite ugly
permission-changing code.
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
---
block/export/fuse.c | 34 ++--------------------------------
1 file changed, 2 insertions(+), 32 deletions(-)
diff --git a/block/export/fuse.c b/block/export/fuse.c
index af0a8de17b..b7a710c29f 100644
--- a/block/export/fuse.c
+++ b/block/export/fuse.c
@@ -503,44 +503,14 @@ static void fuse_getattr(fuse_req_t req, fuse_ino_t inode,
static int fuse_do_truncate(const FuseExport *exp, int64_t size,
bool req_zero_write, PreallocMode prealloc)
{
- uint64_t blk_perm, blk_shared_perm;
BdrvRequestFlags truncate_flags = 0;
- bool add_resize_perm;
- int ret, ret_check;
-
- /* Growable and writable exports have a permanent RESIZE permission */
- add_resize_perm = !exp->growable && !exp->writable;
if (req_zero_write) {
truncate_flags |= BDRV_REQ_ZERO_WRITE;
}
- if (add_resize_perm) {
- if (!qemu_in_main_thread()) {
- /* Changing permissions like below only works in the main thread */
- return -EPERM;
- }
-
- blk_get_perm(exp->common.blk, &blk_perm, &blk_shared_perm);
-
- ret = blk_set_perm(exp->common.blk, blk_perm | BLK_PERM_RESIZE,
- blk_shared_perm, NULL);
- if (ret < 0) {
- return ret;
- }
- }
-
- ret = blk_truncate(exp->common.blk, size, true, prealloc,
- truncate_flags, NULL);
-
- if (add_resize_perm) {
- /* Must succeed, because we are only giving up the RESIZE permission */
- ret_check = blk_set_perm(exp->common.blk, blk_perm,
- blk_shared_perm, &error_abort);
- assert(ret_check == 0);
- }
-
- return ret;
+ return blk_truncate(exp->common.blk, size, true, prealloc,
+ truncate_flags, NULL);
}
/**
--
2.53.0
next prev parent reply other threads:[~2026-03-09 15:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 15:08 [PATCH v5 00/25] export/fuse: Use coroutines and multi-threading Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 01/25] fuse: Copy write buffer content before polling Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 02/25] fuse: Ensure init clean-up even with error_fatal Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 03/25] fuse: Remove superfluous empty line Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 04/25] fuse: Explicitly set inode ID to 1 Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 05/25] fuse: Change setup_... to mount_fuse_export() Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 06/25] fuse: Destroy session on mount_fuse_export() fail Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 07/25] fuse: Fix mount options Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 08/25] fuse: Set direct_io and parallel_direct_writes Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 09/25] fuse: Introduce fuse_{at,de}tach_handlers() Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 10/25] fuse: Introduce fuse_{inc,dec}_in_flight() Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 11/25] fuse: Add halted flag Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 12/25] fuse: fuse_{read,write}: Rename length to blk_len Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 13/25] iotests/308: Use conv=notrunc to test growability Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 14/25] fuse: Explicitly handle non-grow post-EOF accesses Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 15/25] block: Move qemu_fcntl_addfl() into osdep.c Hanna Czenczek
2026-03-09 15:08 ` Hanna Czenczek [this message]
2026-03-09 15:08 ` [PATCH v5 17/25] fuse: Manually process requests (without libfuse) Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 18/25] fuse: Reduce max read size Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 19/25] fuse: Process requests in coroutines Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 20/25] block/export: Add multi-threading interface Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 21/25] iotests/307: Test multi-thread export interface Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 22/25] fuse: Make shared export state atomic Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 23/25] fuse: Implement multi-threading Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 24/25] qapi/block-export: Document FUSE's multi-threading Hanna Czenczek
2026-03-09 15:08 ` [PATCH v5 25/25] iotests/308: Add multi-threading sanity test Hanna Czenczek
2026-03-10 11:13 ` [PATCH v5 00/25] export/fuse: Use coroutines and multi-threading Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309150856.26800-17-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=hibriansong@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.