From: Yonghong Song <yonghong.song@linux.dev>
To: Alan Maguire <alan.maguire@oracle.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
dwarves@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH dwarves v2 5/9] dwarf_loader: Change exprlen checking condition in parameter__reg()
Date: Mon, 9 Mar 2026 08:32:41 -0700 [thread overview]
Message-ID: <20260309153241.1920126-1-yonghong.song@linux.dev> (raw)
In-Reply-To: <20260309153215.1917033-1-yonghong.song@linux.dev>
The change does not change any functionalities. But it allows
DW_OP_stack_value preserved in longer location list for future
parameter checking.
Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
---
dwarf_loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dwarf_loader.c b/dwarf_loader.c
index d538607..2237e20 100644
--- a/dwarf_loader.c
+++ b/dwarf_loader.c
@@ -1226,7 +1226,7 @@ static int parameter__reg(Dwarf_Attribute *attr, int expected_reg, struct cu *cu
* DW_OP_stack_value instructs interpreter to pop current value from
* DWARF expression evaluation stack, and thus is not important here.
*/
- if (exprlen > 1 && expr[exprlen - 1].atom == DW_OP_stack_value)
+ if (exprlen == 2 && expr[exprlen - 1].atom == DW_OP_stack_value)
exprlen--;
if (exprlen != 1)
--
2.47.3
next prev parent reply other threads:[~2026-03-09 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 15:32 [PATCH dwarves v2 0/9] pahole: Encode true signatures in kernel BTF Yonghong Song
2026-03-09 15:32 ` [PATCH dwarves v2 1/9] dwarf_loader: Reduce parameter checking with clang DW_AT_calling_convention attr Yonghong Song
2026-03-09 15:32 ` [PATCH dwarves v2 2/9] dwarf_loader: Handle signatures with dead arguments Yonghong Song
2026-03-09 15:32 ` [PATCH dwarves v2 3/9] dwarf_loader: Refactor initial ret -1 to be macro PARM_DEFAULT_FAIL Yonghong Song
2026-03-09 15:32 ` [PATCH dwarves v2 4/9] dwarf_laoder: Handle locations with DW_OP_fbreg Yonghong Song
2026-03-09 15:32 ` Yonghong Song [this message]
2026-03-09 15:32 ` [PATCH dwarves v2 6/9] dwarf_loader: Detect optimized parameters with locations having constant values Yonghong Song
2026-03-09 15:32 ` [PATCH dwarves v2 7/9] dwarf_loader: Handle expression lists Yonghong Song
2026-03-09 15:32 ` [PATCH dwarves v2 8/9] btf_encoder: Handle optimized parameter properly Yonghong Song
2026-03-09 15:33 ` [PATCH dwarves v2 9/9] tests: Add a few clang true signature tests Yonghong Song
2026-03-09 18:39 ` [PATCH dwarves v2 0/9] pahole: Encode true signatures in kernel BTF Alan Maguire
2026-03-09 19:25 ` Yonghong Song
2026-03-19 16:23 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309153241.1920126-1-yonghong.song@linux.dev \
--to=yonghong.song@linux.dev \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.