From: Jakub Kicinski <kuba@kernel.org>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: netdev@vger.kernel.org, opendmb@gmail.com,
florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
o.rempel@pengutronix.de, rmk+kernel@armlinux.org.uk,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net] net: bcmgenet: fix broken EEE by converting to phylib-managed state
Date: Mon, 9 Mar 2026 18:37:36 -0700 [thread overview]
Message-ID: <20260309183736.1c9b8496@kernel.org> (raw)
In-Reply-To: <20260306083120.1076104-1-nb@tipi-net.de>
On Fri, 6 Mar 2026 09:31:19 +0100 Nicolai Buchwitz wrote:
> @@ -1397,17 +1393,23 @@ static int bcmgenet_get_eee(struct net_device *dev, struct ethtool_keee *e)
> if (!dev->phydev)
> return -ENODEV;
>
> - e->tx_lpi_enabled = p->tx_lpi_enabled;
> + int ret;
> +
> + ret = phy_ethtool_get_eee(dev->phydev, e);
> + if (ret)
> + return ret;
no variable declarations mid-function please.
--
pw-bot: cr
prev parent reply other threads:[~2026-03-10 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 8:31 [PATCH net] net: bcmgenet: fix broken EEE by converting to phylib-managed state Nicolai Buchwitz
2026-03-06 23:59 ` Florian Fainelli
2026-03-10 1:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309183736.1c9b8496@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.