From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8AAC2FFDF7 for ; Mon, 9 Mar 2026 20:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773089079; cv=none; b=ZjjFaP7WGAKoXKU0eEdU5vAIAks4EdZVWTPXslo9WpaJ714L9nOyQBNR54p0ihhUnWtb48s4x8eLzkWfSSKBy/s43GAuDN0CpdDf/B1ukeLizZEvgAs5kuLnJLbtHQg3JEyW7gDRe1fe0EFKTkP8wfY4/xwIsOWArnPUAuv8GnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773089079; c=relaxed/simple; bh=OU8BwV4kZMr6qzKHJItOb2V4zPm15WLNtR75PLdgv2Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QovPVUst48XEuWTvJx/hg3UWd08K9gVTigwhn0HCCKlEUbwA4L+v3CmQfrRZah2BZPFq5tYKkFdc0EZqhDm1pAaba+RkJ/CDgz15KB8rGtFGtrSmWeL4sZGbHbADCdIgV15oHRqiCVrE+PiO99rfi+JbVOkQE5OjO9dYxnzYb1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b=Wcvdl3Va; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b="Wcvdl3Va" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-5033387c80aso152281511cf.0 for ; Mon, 09 Mar 2026 13:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20230601.gappssmtp.com; s=20230601; t=1773089077; x=1773693877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aq9TbVirTT35sLdeT9MWgtOG2gUTPT6aXYvU8bc1x+g=; b=Wcvdl3Va0r6zq0LPi5QgyBLP+NHQBj8yjQYU+4GayqzHGTounbCAS46ormErHwRndV egJvmsNbGU+XmcAMVGY1OQQL45i7RXqN0UMJ6CF1ex45jgSEYQpLuyrxaK0IyF238Dhp aITyb8yYBHdtER+OrGqzCYavP2ZXxNzMrLKGA8qRfNHEaM7RkWkz7oCPqHp9LdGtm/B7 NhDVvZ0o4qA012ZTMnRFvbgsObOsflFhAtQrrfCXEUonpF9sOwVxDlo0fTG36f+fIB0z 8MR95tlz5/L81/sFFWoDk3nS92mE9ycsb3QW0zmpOkN0WAIEOwt9bVJC6TJPtQMAQ+Tg k6sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773089077; x=1773693877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aq9TbVirTT35sLdeT9MWgtOG2gUTPT6aXYvU8bc1x+g=; b=Fuyfv0TsrcB3PKXF3XbRMUpZm913bBWKF+9Sj5oXrEXHHuNOedFGfcAwStJ6WgFCfG nmKxlrKT3FSRjtIMT4iLwO3mAYote4eLORHK62LSDW53TDa6boF8Jv0bOHgc06Yqcf1r UnjJ2reo3rPJcetVCEsCXFH8Qc5g11S2/BdEuWKXJyttZVgZIzRtR2++Z8f1UsUDg4oa eWrKvRrexpU/m82UQTVnnwooUw42jt9X2OSjTchX8uAN8DdDX2PgogWcN48xeOFH9i5G 8tgfIDQ+148ibYxMMFYzVKbINPrSf1lC7/YWvqQJNCJvGs5hka0E48KTrwgQXlF4rfU2 zmMw== X-Gm-Message-State: AOJu0Yxz8doaKS+D6pA1wdkUyP8EUccW50At4pp9fuRjI0oQM++HVizq 5CLOPDAxcCuzN1WcqWobbexYv5tOXe4i+XF5u1C2ZHYKGWydnSqiLZlyubcXpFzkDMAAzLePlVR XbXZT X-Gm-Gg: ATEYQzzvYQbucPayq+Oyw7Pj/XWaJiMUAT5yHuH9mj+n3Zfa5dzRzvEdujaAfZCq89n Y2bAPPO5367OcQ5sWMgMSSabyKEJAEqUNlBSOsaUZKsssNSNdy8cHq5DSw1t0Ro80po3MwBpM3S 8h0EEbPMZL/weW+m8eguiCAzzd1zTT9zvwxIGbCdP1A+3wjb1IUI6BJyaGWt2Fnsw8YHnxP6Y23 iOGHY3T0AkIBMBszni//XBZ5rVu1deB/gL5HBi68XmVrJGfAQqycmfPw3KTwIY99Y3pZ+CNyWSp vw1HNi+JL2OZ3NYhzJu3jnelskQw3B4DWAdy7VCUfy0vh03dibfI/HouyTly4rOSQtr5EhpPC+R w08OzRGyHMdXGXqyoX559Hm9Kq0gmUDlnbRKGZXjVm9uRyHufThJwTVKl5QqtSTuV8Jj9S3DhC9 eqY40pBntrzPGSC4Nbf5iE5A== X-Received: by 2002:a05:622a:6987:b0:509:1d4b:f86b with SMTP id d75a77b69052e-509260f7166mr8354401cf.5.1773089076808; Mon, 09 Mar 2026 13:44:36 -0700 (PDT) Received: from boreas.. ([140.174.219.137]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-508f650ec74sm72109841cf.1.2026.03.09.13.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 13:44:36 -0700 (PDT) From: Emil Tsalapatis To: bpf@vger.kernel.org Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, martin.lau@kernel.org, memxor@gmail.com, song@kernel.org, yonghong.song@linux.dev, Emil Tsalapatis Subject: [PATCH bpf-next v4 2/2] bpf: Add deep call stack selftests Date: Mon, 9 Mar 2026 16:44:30 -0400 Message-ID: <20260309204430.201219-3-emil@etsalapatis.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20260309204430.201219-1-emil@etsalapatis.com> References: <20260309204430.201219-1-emil@etsalapatis.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add tests that demonstrate the verifier support for deep call stacks while still enforcing maximum stack size limits. Acked-by: Eduard Zingerman Signed-off-by: Emil Tsalapatis --- .../bpf/prog_tests/test_global_funcs.c | 2 + .../bpf/progs/test_global_func_deep_stack.c | 83 +++++++++++++++++++ 2 files changed, 85 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/test_global_func_deep_stack.c diff --git a/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c b/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c index e905cbaf6b3d..500446808908 100644 --- a/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c +++ b/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c @@ -18,6 +18,7 @@ #include "test_global_func15.skel.h" #include "test_global_func16.skel.h" #include "test_global_func17.skel.h" +#include "test_global_func_deep_stack.skel.h" #include "test_global_func_ctx_args.skel.h" #include "bpf/libbpf_internal.h" @@ -155,6 +156,7 @@ void test_test_global_funcs(void) RUN_TESTS(test_global_func15); RUN_TESTS(test_global_func16); RUN_TESTS(test_global_func17); + RUN_TESTS(test_global_func_deep_stack); RUN_TESTS(test_global_func_ctx_args); if (test__start_subtest("ctx_arg_rewrite")) diff --git a/tools/testing/selftests/bpf/progs/test_global_func_deep_stack.c b/tools/testing/selftests/bpf/progs/test_global_func_deep_stack.c new file mode 100644 index 000000000000..733c3334b7b1 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/test_global_func_deep_stack.c @@ -0,0 +1,83 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* Copyright (c) 2026 Meta Platforms, Inc and affiliates. */ +#include +#include +#include "bpf_misc.h" + +/* + * Macro tricks to tersely define for long non-recursive call chains. Add + * computation to the functions prevent tail recursion from reducing the + * stack size to 0. + */ + +#define CAT(a, b) a ## b +#define XCAT(a, b) CAT(a, b) + +#define F_0 \ +__attribute__((noinline)) \ +int f0(unsigned long a) { volatile long b = a + 16; if (a == 0) return 0; return b; } + +#define FN(n, prev) \ +__attribute__((noinline)) \ +int XCAT(f, n)(unsigned long a) { volatile long b = XCAT(f, prev)(a - 1); if (!b) return 0; return b + 1; } + +/* Call chain 33 levels deep. */ +#define F_1 F_0 FN(1, 0) +#define F_2 F_1 FN(2, 1) +#define F_3 F_2 FN(3, 2) +#define F_4 F_3 FN(4, 3) +#define F_5 F_4 FN(5, 4) +#define F_6 F_5 FN(6, 5) +#define F_7 F_6 FN(7, 6) +#define F_8 F_7 FN(8, 7) +#define F_9 F_8 FN(9, 8) +#define F_10 F_9 FN(10, 9) +#define F_11 F_10 FN(11, 10) +#define F_12 F_11 FN(12, 11) +#define F_13 F_12 FN(13, 12) +#define F_14 F_13 FN(14, 13) +#define F_15 F_14 FN(15, 14) +#define F_16 F_15 FN(16, 15) +#define F_17 F_16 FN(17, 16) +#define F_18 F_17 FN(18, 17) +#define F_19 F_18 FN(19, 18) +#define F_20 F_19 FN(20, 19) +#define F_21 F_20 FN(21, 20) +#define F_22 F_21 FN(22, 21) +#define F_23 F_22 FN(23, 22) +#define F_24 F_23 FN(24, 23) +#define F_25 F_24 FN(25, 24) +#define F_26 F_25 FN(26, 25) +#define F_27 F_26 FN(27, 26) +#define F_28 F_27 FN(28, 27) +#define F_29 F_28 FN(29, 28) +#define F_30 F_29 FN(30, 29) +#define F_31 F_30 FN(31, 30) +#define F_32 F_31 FN(32, 31) + +#define CAT2(a, b) a ## b +#define XCAT2(a, b) CAT2(a, b) + +#define F(n) XCAT2(F_, n) + +F(32) + +/* Ensure that even 32 levels deep, the function verifies. */ +SEC("syscall") +__success +int global_func_deep_stack_success(struct __sk_buff *skb) +{ + return f31(55); +} + +/* + * Check we actually honor stack limits (33 * 16 = 528 > 512 = MAX_STACK_DEPTH). + * The stack depth is 16 because the verifier calls round_up_stack_depth() on + * the size. + */ +SEC("syscall") +__failure __msg("combined stack size of 34 calls") +int global_func_deep_stack_fail(struct __sk_buff *skb) +{ + return f32(123); +} -- 2.49.0