From: Michael Siebold <michael.siebold@gmail.com>
To: Yoann Congal <yoann.congal@smile.fr>
Cc: bitbake-devel@lists.openembedded.org,
Philip Lorenz <philip.lorenz@bmw.de>,
Richard Purdie <richard.purdie@linuxfoundation.org>,
Michael Siebold <michael.siebold@gmail.com>
Subject: [PATCH 2/3] bitbake: fetch2: Fix incorrect lfs parametrization for submodules
Date: Mon, 9 Mar 2026 14:21:24 -0700 [thread overview]
Message-ID: <20260309212125.3172717-3-michael.siebold@gmail.com> (raw)
In-Reply-To: <20260309212125.3172717-1-michael.siebold@gmail.com>
From: Philip Lorenz <philip.lorenz@bmw.de>
The existing code would pass `True` or `False` to the git fetcher. As
the fetcher expects `lfs` to be set to `1` this always lead to LFS
fetching being disabled.
(Bitbake rev: 5e487a5a096400271ed1e29b0df72903f2304e49)
Upstream-Status: Backport [from commit eb6d89e9e6]
Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit eb6d89e9e6f27b683da6f2ba2227707a965a0094)
Signed-off-by: Michael Siebold <michael.siebold@gmail.com>
---
bitbake/lib/bb/fetch2/gitsm.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bitbake/lib/bb/fetch2/gitsm.py b/bitbake/lib/bb/fetch2/gitsm.py
index ba62517f08..5c98991480 100644
--- a/bitbake/lib/bb/fetch2/gitsm.py
+++ b/bitbake/lib/bb/fetch2/gitsm.py
@@ -123,7 +123,7 @@ class GitSM(Git):
url += ";name=%s" % module
url += ";subpath=%s" % module
url += ";nobranch=1"
- url += ";lfs=%s" % self._need_lfs(ud)
+ url += ";lfs=%s" % ("1" if self._need_lfs(ud) else "0")
# Note that adding "user=" here to give credentials to the
# submodule is not supported. Since using SRC_URI to give git://
# URL a password is not supported, one have to use one of the
--
2.34.1
next prev parent reply other threads:[~2026-03-09 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 21:21 [scarthgap][PATCH 0/3] Fix git lfs submodule expansion Michael Siebold
2026-03-09 21:21 ` [PATCH 1/3] bitbake: gitsm: Add clean function Michael Siebold
2026-03-09 21:21 ` Michael Siebold [this message]
2026-03-09 21:21 ` [PATCH 3/3] bitbake: fetch2: Fix LFS object checkout in submodules Michael Siebold
2026-03-09 21:32 ` Richard Purdie
2026-03-09 23:14 ` Michael Siebold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309212125.3172717-3-michael.siebold@gmail.com \
--to=michael.siebold@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=philip.lorenz@bmw.de \
--cc=richard.purdie@linuxfoundation.org \
--cc=yoann.congal@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.