From: Jenny Guanni Qu <qguanni@gmail.com>
To: bpf@vger.kernel.org
Cc: daniel@iogearbox.net, ast@kernel.org, andrii@kernel.org,
mykyta.yatsenko5@gmail.com, yonghong.song@linux.dev,
lkp@intel.com, Jenny Guanni Qu <qguanni@gmail.com>
Subject: [PATCH v4 0/2] bpf: Fix abs(INT_MIN) undefined behavior in interpreter sdiv/smod
Date: Mon, 9 Mar 2026 21:59:08 +0000 [thread overview]
Message-ID: <20260309215910.4131143-1-qguanni@gmail.com> (raw)
The BPF interpreter's signed 32-bit division and modulo handlers use
abs() on s32 operands, which is undefined for S32_MIN. This causes
the interpreter to compute wrong results, creating a mismatch with
the verifier's range tracking.
For example, INT_MIN / 2 returns 0x40000000 instead of the correct
0xC0000000. The verifier tracks the correct range, so a crafted BPF
program can exploit the mismatch for out-of-bounds map value access
(confirmed by KASAN).
Patch 1 introduces __safe_abs32() which handles S32_MIN correctly
and replaces all 8 abs((s32)...) call sites.
Patch 2 adds selftests covering sdiv32 and smod32 with INT_MIN
dividend to prevent regression.
Changes since v3:
- Fixed stray blank line deletion in the file header
- Improved __safe_abs32() comment per Yonghong Song's suggestion
- Added JIT vs interpreter context to selftest commit message
per Yonghong Song's feedback
Changes since v2:
- Simplified __safe_abs32() to use -(u32)x instead of special-casing
S32_MIN, per Mykyta Yatsenko's suggestion
Changes since v1:
- Moved __safe_abs32() helper above the kerneldoc comment block
for ___bpf_prog_run() to fix build warnings reported by
kernel test robot
Jenny Guanni Qu (2):
bpf: Fix undefined behavior in interpreter sdiv/smod for INT_MIN
selftests/bpf: Add tests for sdiv32/smod32 with INT_MIN dividend
kernel/bpf/core.c | 22 ++++---
.../selftests/bpf/progs/verifier_sdiv.c | 58 +++++++++++++++++++
2 files changed, 72 insertions(+), 8 deletions(-)
--
2.34.1
next reply other threads:[~2026-03-09 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 21:59 Jenny Guanni Qu [this message]
2026-03-09 21:59 ` [PATCH v4 1/2] bpf: Fix undefined behavior in interpreter sdiv/smod for INT_MIN Jenny Guanni Qu
2026-03-10 0:28 ` Mykyta Yatsenko
2026-03-10 19:03 ` Alexei Starovoitov
2026-03-09 21:59 ` [PATCH v4 2/2] selftests/bpf: Add tests for sdiv32/smod32 with INT_MIN dividend Jenny Guanni Qu
2026-03-10 2:05 ` Jiayuan Chen
2026-03-10 2:20 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309215910.4131143-1-qguanni@gmail.com \
--to=qguanni@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=lkp@intel.com \
--cc=mykyta.yatsenko5@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.