Re: [RFC PATCH v2 2/6] mm/damon/core: introduce struct damon_access_report

[SeongJae Park <sj@kernel.org>]

On Mon, 9 Mar 2026 08:19:53 -0700 Ian Rogers <irogers@google.com> wrote:

> On Sun, Mar 8, 2026 at 6:00 PM Akinobu Mita <akinobu.mita@gmail.com> wrote:
> >
> > The struct damon_access_report is borrowed from SeongJae Park's
> > DAMON extension project [1].
> >
> > [1] https://lore.kernel.org/linux-mm/20251208062943.68824-6-sj@kernel.org/T/
> > ---
> >  include/linux/damon.h | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/include/linux/damon.h b/include/linux/damon.h
> > index 49d2983af4a8..5f2870ae02ba 100644
> > --- a/include/linux/damon.h
> > +++ b/include/linux/damon.h
> > @@ -110,6 +110,30 @@ struct damon_target {
> >         bool obsolete;
> >  };
> >
> > +/**
> > + * struct damon_access_report - Represent single acces report information.
> 
> nit: typo s/acces/access/
> 
> > + * @paddr:             Start physical address of the accessed address range.
> > + * @vaddr:             Start virtual address of the accessed address range.
> > + * @size:              The size of the accessed address range.
> > + * @cpu:               The id of the CPU that made the access.
> > + * @tid:               The task id of the task that made the access.
> > + * @is_write:          Whether the access is write.
> > + *
> > + * Any DAMON API callers that notified access events can report the information
> > + * to DAMON using damon_report_access().  This struct contains the reporting
> > + * infomration.  Refer to damon_report_access() for more details.
> 
> nit: typo s/infomration/information/

As Akinobu kindly commented above, this change is borrowed from my tree, and
these typos also came from there. Thank you for catching these, Ian!  I fixed
these in my tree.


Thanks,
SJ

[...]