From: Rosen Penev <rosenp@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-hardening@vger.kernel.org, gustavoars@kernel.org,
Viresh Kumar <vireshk@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
virtualization@lists.linux.dev (open list:VIRTIO GPIO DRIVER),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] gpio: virtio: remove one kcalloc
Date: Mon, 9 Mar 2026 19:00:57 -0700 [thread overview]
Message-ID: <20260310020057.340550-1-rosenp@gmail.com> (raw)
A flexible array member can be used to combine allocations.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/gpio/gpio-virtio.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c
index ed6e0e90fa8a..876a34ed739d 100644
--- a/drivers/gpio/gpio-virtio.c
+++ b/drivers/gpio/gpio-virtio.c
@@ -52,7 +52,6 @@ struct virtio_gpio {
struct virtio_device *vdev;
struct mutex lock; /* Protects virtqueue operation */
struct gpio_chip gc;
- struct virtio_gpio_line *lines;
struct virtqueue *request_vq;
/* irq support */
@@ -60,6 +59,7 @@ struct virtio_gpio {
struct mutex irq_lock; /* Protects irq operation */
raw_spinlock_t eventq_lock; /* Protects queuing of the buffer */
struct vgpio_irq_line *irq_lines;
+ struct virtio_gpio_line lines[];
};
static int _virtio_gpio_req(struct virtio_gpio *vgpio, u16 type, u16 gpio,
@@ -541,10 +541,6 @@ static int virtio_gpio_probe(struct virtio_device *vdev)
u16 ngpio;
int ret, i;
- vgpio = devm_kzalloc(dev, sizeof(*vgpio), GFP_KERNEL);
- if (!vgpio)
- return -ENOMEM;
-
/* Read configuration */
gpio_names_size =
virtio_cread32(vdev, offsetof(struct virtio_gpio_config,
@@ -556,8 +552,8 @@ static int virtio_gpio_probe(struct virtio_device *vdev)
return -EINVAL;
}
- vgpio->lines = devm_kcalloc(dev, ngpio, sizeof(*vgpio->lines), GFP_KERNEL);
- if (!vgpio->lines)
+ vgpio = devm_kzalloc(dev, struct_size(vgpio, lines, ngpio), GFP_KERNEL);
+ if (!vgpio)
return -ENOMEM;
for (i = 0; i < ngpio; i++) {
--
2.53.0
next reply other threads:[~2026-03-10 2:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 2:00 Rosen Penev [this message]
2026-03-10 5:01 ` [PATCH] gpio: virtio: remove one kcalloc Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310020057.340550-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=brgl@kernel.org \
--cc=gustavoars@kernel.org \
--cc=info@metux.net \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vireshk@kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.