From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75A903ED12B for ; Tue, 10 Mar 2026 08:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130910; cv=none; b=gYfs3lumdOaZfmVO5LLekaCkzdvlk8avOPCCfkMB5ZJgrh3zSXe9bCS/F3ckKBgftR22bLpPEH33DmGYDmu/glVcP/sDkxQhlbE9jdfT0P48xs+/9/S4yJQ0/bu8YNaMVQ7ejfnTFn+atRub0IrR6KIIFtnQJ87Eim1xz388ROw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773130910; c=relaxed/simple; bh=ZZHUjKKqIgLaXnDqZ0lastsWqmLdTRPc+UVwW1EmnG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iIxnImT2fuMeImh2qnzuh89E+QxTYqztZFrhbQhcsrUgO0gq81VnxJt76RnUK6sHvBt00ZdLzYctiW+XPnJNXUVFg6xIIsKq1qxjlrkhODA4NAROYE6r5IJjScXvSNifHbvmMTHbpqsgUu3OulLfLoSeC6XuXiF2K9U09/oZm4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lEgCFmAW; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lEgCFmAW" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48539d21b76so15614385e9.1 for ; Tue, 10 Mar 2026 01:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773130908; x=1773735708; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G2jT+S0SaYeK0BFzJ0Wmjh4nCNBW/uyn/XMLpq/8Vls=; b=lEgCFmAW5TJZp/NTpB/JiAT1Pm05Qo8ss6vP1jDMhoZNIOjVLKJ5QpxeQqMgiCv0gx +midAN7Pb4KeqvR/JGnPX/D6RaGfHH755LtSx2Wq4SfQPrpNm/J9eJ/kqaIkIMPGnBDZ jo/iz6nKTReeWtKO7U2kCRYbuqVzSR8l9wUpmIWklfAZ5bCuAZXMQo8XsOnKcoEH7u77 7ynQjCiSSjKxkvp8d8HsEmdiR1q7VOBKmdGM4deNm/NiIF7FdEL6lpsXDi629iMGn5aG NFgHZw/TVt+hRz25Z64boRZmJKDM3tB3QcaMNQpj6YCqD+prkAXYTpO0yrP2PXZY/ajd DQHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773130908; x=1773735708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G2jT+S0SaYeK0BFzJ0Wmjh4nCNBW/uyn/XMLpq/8Vls=; b=uuH+3h0TOd+O53VChpZFCJ0ZMIhbJj+FC5uMlISg2fVbGICYQ5jhnLWF+b8qQ1Jx61 iH1+k9EszQaPQ9MLOEdUICGSOBYGkcB3E45mLlQ6iQoiiSAY/Xdrl0CTI2TN5znLoNxo zTHVxV1DvdIrCcLFqhy9XnJw51w+kcPKcNOQ8f4d/Vek3p2xiemLf/reOfqWTHuDQDCu K6mvQpcxpd/2R2F5n5Ke/GicfWfsV+ZKA1DkEA7KSXv9yFje8gj6/92lN9RAh7aQH0mB awN5jiRPKNEeynpdS/uI5g4SdRK5DZqDlH7a4mUxfimq3mR3iTDG89fSvJKu4WeJhvfQ LKHw== X-Forwarded-Encrypted: i=1; AJvYcCW4B+hlJWQfXSKK+wjBdpvAR+cl6RnKYZ1hP3ATkMPhY7POqyzf5dHsNjGaZNrQdlxiYPBoC7Y6mtCccic=@vger.kernel.org X-Gm-Message-State: AOJu0YynEe4EK6bS9ha0X2DJJ9DPE0Ru/ifDP5xwoHJUbEkCXYJ47L4N MhCYV/U78URTbhQ4IYgqnEEgQxA4HEzMasUUl0VOOSEdUsDUvltA3uIN X-Gm-Gg: ATEYQzxPy4nV/u12o+J19KqLJZapyZKgysfhNJc1v/JAeqlsBqeQfvIN34yaK47+n12 Tyun6zmbXyXjW7XEGIWusLdNAvhJlPRuK4+Kot/4D7Lxqa1fnjpyF1gmX54ZRKlvy9WTUGzAcWc QDnMi/M6jmjIpa6Ckgs5p8R1JqnjYQQIRvcifP61lp36fkwdb7ZAW6qMWFkbYrs4yLteFJ2R0MT lYSS+SmPvZYt5J1XmtT7Yxop9dAIWtpjXxASnbRRq9j84O1laTCP8o3pixxtcNnhmzFehj2308w 0MZUhF1DSe5V6fy4mhvCsfhjDfrQdl3fVpLmHN3dgyWHfgCgtaUsmvdBlBYM56QREhrK6rfAexx 8PzzUkXnh1f3uSvhclGnagcbYTyneEr/dkMGEV3ZtY/KyrC7sX+ssZtriZXAAscK0a5eRqHDGTn Jn6mauSMJdNXpaX4MMWiiufHvnwMI+eQr7IZFothfwxwZLk/6ChMWB47ssLNULrd3mEbG+lI1rM ecvgc79ABE9UkNkSa2DIAelKq3DHiAqQ1lGQWvOprlD X-Received: by 2002:a05:600c:4f49:b0:485:3dfc:569 with SMTP id 5b1f17b1804b1-4853dfc06f1mr85448365e9.16.1773130907744; Tue, 10 Mar 2026 01:21:47 -0700 (PDT) Received: from fedora ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8daf2sm34960352f8f.2.2026.03.10.01.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 01:21:47 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Peter Zijlstra (Intel)" Subject: [PATCH -tip 2/3] x86/segment: Remove unnecessary memory clobber from savesegment() Date: Tue, 10 Mar 2026 09:21:23 +0100 Message-ID: <20260310082142.93834-2-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260310082142.93834-1-ubizjak@gmail.com> References: <20260310082142.93834-1-ubizjak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The savesegment() macro uses inline assembly to copy a segment register into a general-purpose register: movl %seg, reg This instruction does not access memory, yet the inline asm currently declares a "memory" clobber, which unnecessarily acts as a compiler barrier and may inhibit optimization. Remove the "memory" clobber and mark the asm as `asm volatile` instead. Segment register loads in the kernel are implemented using `asm volatile`, and the compiler should not schedule segment register reads before those loads. Using `asm volatile` preserves the intended ordering with other segment register operations without imposing an unnecessary global memory barrier. No functional change intended. Signed-off-by: Uros Bizjak Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: "Peter Zijlstra (Intel)" --- arch/x86/include/asm/segment.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h index 9f5be2bbd291..3fe3a310844c 100644 --- a/arch/x86/include/asm/segment.h +++ b/arch/x86/include/asm/segment.h @@ -348,7 +348,7 @@ static inline void __loadsegment_fs(unsigned short value) * Save a segment register away: */ #define savesegment(seg, value) \ - asm("movl %%" #seg ",%k0" : "=r" (value) : : "memory") + asm volatile("movl %%" #seg ",%k0" : "=r" (value)) #endif /* !__ASSEMBLER__ */ #endif /* __KERNEL__ */ -- 2.53.0