From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB0A34D917 for ; Tue, 10 Mar 2026 08:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773132251; cv=none; b=jy5n+aur3MIYFWkdYeEUvMnLlLa7ZkSXzjqppeucCVwViRfGBA7DKtCCcuq2ykYQhqYUQXsNBltltXWs71h4v2Uu4NTrnJ2gUmw9GHzgtmSuF4C6kFh+++v/wgoE7A3A2FpF0mJUX6XjBGny4wdaQB9D2Oz5dp9w6t+5z380ikc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773132251; c=relaxed/simple; bh=bO4CoERUMsZ0TON44WIK8gTeMmgpLszBQyrJ7vBOg4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XLF+Pv2qEbi3WKIzcPRhES9RUaCJECkNIExS4l+Ug1CvlRCqj4tuAV6QAkZ670Y8RVqsGJwkoaTqapqXBo5iv5JXDrZQzDBHdRfrmQhBASd84vIJg48NUe93jY9kDAtssmQ3tJ4wPfv4AUDnJJ0EMlGHeaAHqdRVOPoGO3DH82U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 064E968C4E; Tue, 10 Mar 2026 09:44:06 +0100 (CET) Date: Tue, 10 Mar 2026 09:44:05 +0100 From: Christoph Hellwig To: Andrey Albershteyn Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, ebiggers@kernel.org, hch@lst.de, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH v4 07/25] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity Message-ID: <20260310084405.GA17112@lst.de> References: <20260309192355.176980-1-aalbersh@kernel.org> <20260309192355.176980-8-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309192355.176980-8-aalbersh@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) > +static bool iomap_writeback_handle_eof(struct folio *folio, > + struct iomap_writepage_ctx *wpc, > + u64 *end_pos) Please keep the old double tab indentation here instead of this very hard to read and modify version. Otherwise this looks good. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7CE2FCC9DB for ; Tue, 10 Mar 2026 08:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hHm9O2colGSdZd6Vc3JWYUCSP+mc96zQI1sBXQ3xIwo=; b=aBrLYk6qGdRlO8FSXI9DbyZMwn Bnn7cfvX6n5hXwLrNs2kffkIGb0vkjFxwnPBUeZ+DcDbsfLvTcQE9dxTCoVWPzu+9qtkiOLFj/kxZ HN36ISOpvUaC7YtqWW29s2jjd+x92YOWOP3druNDVC1kXggBcIcY/iPJtafRsxx7mW1A=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vzshM-00020b-C4; Tue, 10 Mar 2026 08:44:17 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vzshL-00020S-3H for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Mar 2026 08:44:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kPXoAZz+Q9V8iMCWbwde3YDroZUZUf/crWjlk+difwU=; b=cb3yoURwvMTrBNeSmhWBm7MAfk yuIPFjfKh730md8MbMnLrRLr/XNrKHk1FxHs7Ms5UzjVuQimwcsyngFJNPe+gCeDHuRe5Nz5AUj8m EqoLHZx4DyKOdO8k6UEzzcI1TkWFAYuyUMWTUoARGiGtriMMzV2tJugHpnEt7h9RJX0w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kPXoAZz+Q9V8iMCWbwde3YDroZUZUf/crWjlk+difwU=; b=ipLz6/nlyz+a9xyKPjTco36S+L bYb9wuY+fbviKMJchxM+Un4TDwCt7nVUYPnlVeeezTpsLwj6IFzqcX51tZsN4R52b/ONIBW87K49h b0GMzI02nSHOFaWsEcgnFPgYVgmVHwDztuKTR8VWAWiFxj7it+G1m89KyHDp94BKxiVU=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vzshL-0008DR-6z for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Mar 2026 08:44:15 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 064E968C4E; Tue, 10 Mar 2026 09:44:06 +0100 (CET) Date: Tue, 10 Mar 2026 09:44:05 +0100 From: Christoph Hellwig To: Andrey Albershteyn Message-ID: <20260310084405.GA17112@lst.de> References: <20260309192355.176980-1-aalbersh@kernel.org> <20260309192355.176980-8-aalbersh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260309192355.176980-8-aalbersh@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1vzshL-0008DR-6z Subject: Re: [f2fs-dev] [PATCH v4 07/25] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fsverity@lists.linux.dev, ebiggers@kernel.org, djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net > +static bool iomap_writeback_handle_eof(struct folio *folio, > + struct iomap_writepage_ctx *wpc, > + u64 *end_pos) Please keep the old double tab indentation here instead of this very hard to read and modify version. Otherwise this looks good. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel