Re: [PATCH 1/3] xfs: add a couple helpers to alloc/free xfs_busy_extents

[Christoph Hellwig <hch@lst.de>]

On Tue, Mar 10, 2026 at 01:33:14PM +0100, cem@kernel.org wrote:
> The avoid calls like xfs_busy_extents_alloc(0) explicitly pass GFP_KERNEL
> as argument. It looks better to me.

You can't really pass 0 anyway, so I think this part of the commit
log doesn't make much sense.

> +static inline struct xfs_busy_extents *
> +xfs_busy_extents_alloc(gfp_t flags)
> +{
> +	struct xfs_busy_extents *e;
> +	e = kzalloc_obj(*e, flags);

Please keep an empty line between declarations and code.  And in this
case you could probably move the initialization to the declaration line
as well.
>
> +	if (e)
> +		INIT_LIST_HEAD(&e->extent_list);
> +	return e;
> +}
> +
> +static inline void xfs_busy_extents_free(
> +	struct xfs_busy_extents *e)

This is inconsistent with the xfs_busy_extents_alloc prototype above,
which uses the mormal kernel style, which we sometimes do for inlines,
but also doesn't use the XFS style with the return type on a separate
line and the argument names tab indented.