From: Denys Dmytriyenko <denis@denix.org>
To: s-sadik@ti.com
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti] [master][PATCH v2 3/3] ti-jailhouse: Fix buildpaths QA warning
Date: Tue, 10 Mar 2026 09:52:47 -0400 [thread overview]
Message-ID: <20260310135247.GS11121@denix.org> (raw)
In-Reply-To: <317026.1773133125690466392@lists.yoctoproject.org>
On Tue, Mar 10, 2026 at 01:58:45AM -0700, Sadik via lists.yoctoproject.org wrote:
> On Tue, Mar 10, 2026 at 12:28 AM, Denys Dmytriyenko wrote:
>
> >
> > On Mon, Mar 09, 2026 at 12:08:36PM -0500, Ryan Eatmon via
> > lists.yoctoproject.org wrote:
> > >
> > >
> > > On 3/9/2026 12:01 PM, Mahammed Sadik Shaik wrote:
> > > >Add -ffile-prefix-map flags to KCFLAGS to remove build path
> > > >references from kernel module compilation, ensuring reproducible
> > > >builds and preventing absolute path leakage in binaries.
> > > >
> > > >This resolves buildpaths QA warnings during packaging.
> > > >
> > > >Signed-off-by: Mahammed Sadik Shaik <s-sadik@ti.com>
> > > >---
> > > > meta-ti-extras/recipes-ti/jailhouse/ti-jailhouse.inc | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > >diff --git a/meta-ti-extras/recipes-ti/jailhouse/ti-jailhouse.inc
> > b/meta-ti-extras/recipes-ti/jailhouse/ti-jailhouse.inc
> > > >index 91076c9e..8308f0e5 100644
> > > >--- a/meta-ti-extras/recipes-ti/jailhouse/ti-jailhouse.inc
> > > >+++ b/meta-ti-extras/recipes-ti/jailhouse/ti-jailhouse.inc
> > > >@@ -80,8 +80,8 @@ USER_SPACE_CFLAGS = '${CFLAGS}
> > -DLIBEXECDIR=\\\"${libexecdir}\\\" \
> > > > TOOLS_SRC_DIR = "${S}/tools"
> > > >-EXTRA_OEMAKE = "ARCH=${JH_ARCH} CROSS_COMPILE=${TARGET_PREFIX} CC="${CC}"
> > KDIR=${STAGING_KERNEL_BUILDDIR}"
> > > >-
> > > >+EXTRA_OEMAKE = "ARCH=${JH_ARCH} CROSS_COMPILE=${TARGET_PREFIX} CC="${CC}"
> > KDIR=${STAGING_KERNEL_BUILDDIR} \
> > > >+ KCFLAGS='-ffile-prefix-map=${STAGING_KERNEL_BUILDDIR}/=
> > -ffile-prefix-map=${STAGING_KERNEL_DIR}/='"
> > > > do_compile() {
> > > > oe_runmake V=1
> > > > }
> >
> > Can you move V=1 into EXTRA_OEMAKE and remove overriding do_compile()
>
> Thanks for the review Denys, Apologies for multiple replies was facing some issues with relply all in mail.
>
> Moving V=1 into EXTRA_OEMAKE is fine, but we can't remove the do_compile() override. . This is insufficient for jailhouse, which requires building:
> 1. Kernel modules (driver/jailhouse.ko)
> 2. Hypervisor binary (hypervisor/jailhouse.bin)
> 3. Userspace tools (tools/jailhouse, jailhouse-*)
> 4. Inmate demos (inmates/demos/*) — causing the install failure for all the demos during the build.
>
> The do_compile() override is needed to run a plain oe_runmake which hits jailhouse's top-level Makefile and builds the full project.
The default do_compile() does exactly that - calls oe_runmake:
https://git.openembedded.org/openembedded-core/tree/meta/classes-global/base.bbclass#n399
> If necessary I can send an V3 by moving V=1 into EXTRA_OEMAKE, but that doesn't serve our purpose of completely overriding the do_compile
> And also I couldn't find an existing bbclass that does "run the top-level Makefile and build everything."
>
> >
> >
> > > Thank you. I was going to comment on the v1 to not disable buildpaths.
> >
> > +1
next prev parent reply other threads:[~2026-03-10 13:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 17:01 [master][PATCH v2 0/3] jailhouse: Fix build issues and QA warnings Mahammed Sadik Shaik
2026-03-09 17:01 ` [master][PATCH v2 1/3] jailhouse: Fix JH_RAMFS image path Mahammed Sadik Shaik
2026-03-09 17:01 ` [master][PATCH v2 2/3] jailhouse-inmate: Inhibit debug package split Mahammed Sadik Shaik
2026-03-09 17:01 ` [master][PATCH v2 3/3] ti-jailhouse: Fix buildpaths QA warning Mahammed Sadik Shaik
2026-03-09 17:08 ` Ryan Eatmon
2026-03-09 18:58 ` [meta-ti] " Denys Dmytriyenko
2026-03-10 8:58 ` Sadik
2026-03-10 13:46 ` [meta-ti] " Andrew Davis
2026-03-10 17:11 ` Sadik
2026-03-10 13:52 ` Denys Dmytriyenko [this message]
2026-03-10 17:08 ` Sadik
2026-03-10 17:58 ` [meta-ti] " Andrew Davis
2026-03-10 19:35 ` Ryan Eatmon
2026-03-10 23:58 ` Sadik
2026-03-09 17:18 ` [master][PATCH v2 0/3] jailhouse: Fix build issues and QA warnings PRC Automation
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310135247.GS11121@denix.org \
--to=denis@denix.org \
--cc=meta-ti@lists.yoctoproject.org \
--cc=s-sadik@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.