From: Bjorn Helgaas <helgaas@kernel.org>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
alok.a.tiwarilinux@gmail.com
Subject: Re: [PATCH] PCI: Fix incorrect retval type in remove_id_store()
Date: Tue, 10 Mar 2026 11:03:47 -0500 [thread overview]
Message-ID: <20260310160347.GA680013@bhelgaas> (raw)
In-Reply-To: <3ad69182-8e04-4a44-99d9-c55e2fabc3b2@oracle.com>
On Tue, Mar 10, 2026 at 08:36:25AM +0530, ALOK TIWARI wrote:
> On 3/10/2026 3:50 AM, Bjorn Helgaas wrote:
> > On Tue, Feb 24, 2026 at 10:14:29AM -0800, Alok Tiwari wrote:
> > > remove_id_store() initializes retval with -ENODEV, but retval was
> > > declared as size_t. Since size_t is unsigned, the negative value is
> > > converted to a large positive number, breaking error handling.
> >
> > Does this actually cause a problem?
Can you answer this question? I think the patch itself is OK, but I
don't want to claim that it fixes broken error handling unless there's
actually some way to observe that broken behavior.
next prev parent reply other threads:[~2026-03-10 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 18:14 [PATCH] PCI: Fix incorrect retval type in remove_id_store() Alok Tiwari
2026-03-09 22:20 ` Bjorn Helgaas
2026-03-10 3:06 ` ALOK TIWARI
2026-03-10 16:03 ` Bjorn Helgaas [this message]
2026-03-19 15:45 ` ALOK TIWARI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310160347.GA680013@bhelgaas \
--to=helgaas@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=alok.a.tiwarilinux@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.