From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
skhan@linuxfoundation.org, me@brighamcampbell.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Taha Ed-Dafili <0rayn.dev@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH v2 1/5] dt-bindings: iio: dac: ad5504: add output-range and missing gpios
Date: Tue, 10 Mar 2026 17:48:31 +0000 [thread overview]
Message-ID: <20260310174835.24209-2-0rayn.dev@gmail.com> (raw)
In-Reply-To: <20260310174835.24209-1-0rayn.dev@gmail.com>
The AD5504 output range (0-30V or 0-60V) is determined by the R_SEL pin.
Use standard output-range-microvolt and range-sel-gpios properties to
describe the hardware configuration of the R_SEL pin. Ensure mutual
exclusivity using the not/required logic. Additionally, add missing
vlogic-supply, clear-gpios, ldac-gpios and datasheet links, and provide
a complete usage example.
Suggested-by: David Lechner <dlechner@baylibre.com>
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com>
---
.../bindings/iio/dac/adi,ad5504.yaml | 40 ++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml
index 9c2c038683b4..c0b2d470949a 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml
@@ -10,8 +10,10 @@ maintainers:
- Lars-Peter Clausen <lars@metafoo.de>
- Jonathan Cameron <jic23@kernel.org>
-description:
+description: |
High voltage (up to 60V) DACs with temperature sensor alarm function
+ https://www.analog.com/media/en/technical-documentation/data-sheets/ad5504.pdf
+ https://www.analog.com/media/en/technical-documentation/data-sheets/ad5501.pdf
properties:
compatible:
@@ -27,16 +29,48 @@ properties:
maxItems: 1
vcc-supply: true
+ vlogic-supply: true
+
+ output-range-microvolt:
+ description: |
+ Specify the channel output full scale range. The R_SEL pin
+ determines if the range is 0-30V or 0-60V.
+ items:
+ - const: 0
+ - enum: [30000000, 60000000]
+ default: [0, 60000000]
+
+ range-sel-gpios:
+ description:
+ GPIO connected to the R_SEL pin to select the output voltage range.
+ maxItems: 1
+
+ clear-gpios:
+ description: GPIO that controls the /CLR pin (active low).
+ maxItems: 1
+
+ ldac-gpios:
+ description: GPIO that controls the /LDAC pin (active low).
+ maxItems: 1
additionalProperties: false
required:
- compatible
- reg
+ - vcc-supply
+
+allOf:
+ - not:
+ required:
+ - range-sel-gpios
+ - output-range-microvolt
examples:
- |
#include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/gpio/gpio.h>
+
spi {
#address-cells = <1>;
#size-cells = <0>;
@@ -45,6 +79,10 @@ examples:
compatible = "adi,ad5504";
vcc-supply = <&dac_vcc>;
interrupts = <55 IRQ_TYPE_EDGE_FALLING>;
+
+ output-range-microvolt = <0 60000000>;
+ clear-gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
+ ldac-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
};
};
...
--
2.47.3
next prev parent reply other threads:[~2026-03-10 17:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 17:48 [PATCH v2 0/5] iio: dac: ad5504: fix voltage scaling and add missing bindings Taha Ed-Dafili
2026-03-10 17:48 ` Taha Ed-Dafili [this message]
2026-03-10 20:11 ` [PATCH v2 1/5] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Krzysztof Kozlowski
2026-03-11 9:49 ` Taha Ed-Dafili
2026-03-15 12:42 ` Jonathan Cameron
2026-03-11 11:57 ` Nuno Sá
2026-03-10 17:48 ` [PATCH v2 2/5] iio: dac: ad5504: sort headers alphabetically Taha Ed-Dafili
2026-03-10 18:20 ` Andy Shevchenko
2026-03-10 20:15 ` Krzysztof Kozlowski
2026-03-15 12:47 ` Jonathan Cameron
2026-03-10 17:48 ` [PATCH v2 3/5] iio: dac: ad5504: Align headers with IWYU principle Taha Ed-Dafili
2026-03-10 18:32 ` Andy Shevchenko
2026-03-10 17:48 ` [PATCH v2 4/5] iio: dac: ad5504: fix scale via output-range-microvolt Taha Ed-Dafili
2026-03-10 19:16 ` Andy Shevchenko
2026-03-11 9:54 ` [PATCH v2 3/5] iio: dac: ad5504: Align headers with IWYU principle Taha Ed-Dafili
2026-03-11 12:05 ` [PATCH v2 4/5] iio: dac: ad5504: fix scale via output-range-microvolt Nuno Sá
2026-03-10 20:16 ` Krzysztof Kozlowski
2026-03-10 17:48 ` [PATCH v2 5/5] iio: dac: ad5504: add optional GPIO control for CLR and LDAC Taha Ed-Dafili
2026-03-11 11:59 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310174835.24209-2-0rayn.dev@gmail.com \
--to=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.