Re: [PATCH v3 3/5] vgaarb: mark vga_get() and wrappers as __must_check

[Bjorn Helgaas <helgaas@kernel.org>]

On Sun, Mar 08, 2026 at 02:35:36AM +0900, Simon Richter wrote:
> The vga_get() function and the two wrappers vga_get_interruptible() and
> vga_get_uninterruptible() can return errors. As these are paired with
> vga_put(), which must only be called after vga_get() returned success, all
> callers need to check the return code.
> 
> Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> ---
>  include/linux/vgaarb.h | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
> index 97129a1bbb7d..eed524c67c22 100644
> --- a/include/linux/vgaarb.h
> +++ b/include/linux/vgaarb.h
> @@ -27,7 +27,8 @@ struct pci_dev;
>  
>  #ifdef CONFIG_VGA_ARB
>  void vga_set_legacy_decoding(struct pci_dev *pdev, unsigned int decodes);
> -int vga_get(struct pci_dev *pdev, unsigned int rsrc, int interruptible);
> +int __must_check vga_get(struct pci_dev *pdev, unsigned int rsrc,
> +			 int interruptible);

vga_get() is implemented in vgaarb.c and is only used there.  Can we
drop this declaration and the stub below, make it static and
__must_check in vgaarb.c?

>  void vga_put(struct pci_dev *pdev, unsigned int rsrc);
>  struct pci_dev *vga_default_device(void);
>  void vga_set_default_device(struct pci_dev *pdev);
> @@ -39,8 +40,8 @@ static inline void vga_set_legacy_decoding(struct pci_dev *pdev,
>  		unsigned int decodes)
>  {
>  };
> -static inline int vga_get(struct pci_dev *pdev, unsigned int rsrc,
> -		int interruptible)
> +static inline int __must_check vga_get(struct pci_dev *pdev, unsigned int rsrc,
> +				       int interruptible)
>  {
>  	return 0;
>  }