All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "David Marinović" <david.marinovic@pupin.rs>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	 andy@kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,  robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	 michael.hennerich@analog.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings
Date: Wed, 11 Mar 2026 14:04:35 +0100	[thread overview]
Message-ID: <20260311-sassy-successful-earwig-afbd8e@quoll> (raw)
In-Reply-To: <4915e1023c72d2681b0c4ae028ec609e@pupin.rs>

On Tue, Mar 10, 2026 at 04:32:05PM +0100, David Marinović wrote:
> Add DT compatible strings for the LTC2654 DAC family variants
> supported by the ltc2632 driver.
> 
> Signed-off-by: David Marinovic <david.marinovic@pupin.rs>
> ---
>  .../devicetree/bindings/iio/dac/lltc,ltc2632.yaml        | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof


  parent reply	other threads:[~2026-03-11 13:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 15:27 [PATCH 0/2] iio: dac: ltc2632: add support for LTC2654 DAC family David Marinović
2026-03-10 15:29 ` [PATCH 1/2] " David Marinović
2026-03-11 12:18   ` Andy Shevchenko
2026-03-10 15:32 ` [PATCH 2/2] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings David Marinović
2026-03-11 13:03   ` Krzysztof Kozlowski
2026-03-11 13:04   ` Krzysztof Kozlowski [this message]
2026-03-18 13:57 ` [PATCH v2 0/3] iio: dac: ltc2632: add support for LTC2654 DAC family David Marinović
2026-03-18 13:57   ` [PATCH 1/3] iio: dac: ltc2632: drop enum and use individual chip_info objects David Marinović
2026-03-18 14:57     ` Andy Shevchenko
2026-03-18 13:57   ` [PATCH 2/3] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings David Marinović
2026-03-18 17:38     ` Conor Dooley
2026-03-18 13:57   ` [PATCH 3/3] iio: dac: ltc2632: add support for LTC2654 DAC family David Marinović
2026-03-20 15:09   ` [PATCH v3 0/3] " David Marinović
2026-03-20 15:09     ` [PATCH v3 1/3] iio: dac: ltc2632: drop enum and use individual chip_info objects David Marinović
2026-03-20 15:09     ` [PATCH v3 2/3] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings David Marinović
2026-03-20 17:20       ` Conor Dooley
2026-03-21 15:39         ` Jonathan Cameron
2026-03-20 15:09     ` [PATCH v3 3/3] iio: dac: ltc2632: add support for LTC2654 DAC family David Marinović
2026-03-21 15:38       ` Jonathan Cameron
2026-03-21 15:30     ` [PATCH v3 0/3] " Jonathan Cameron
2026-03-21 15:41     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311-sassy-successful-earwig-afbd8e@quoll \
    --to=krzk@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david.marinovic@pupin.rs \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.