Re: [PATCH v2 07/10] net/mlx5: add testpmd command to query per-queue rate limit

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed, 11 Mar 2026 00:26:50 +0100
Vincent Jardin <vjardin@free.fr> wrote:

> Add a new testpmd command to display the per-queue packet pacing
> rate limit state, including the PP index from both driver state
> and FW SQ context readback:
> 
>   testpmd> mlx5 port <port_id> txq <queue_id> rate show  
> 
> This helps verify that the FW actually applied the PP index to
> the SQ after setting a per-queue rate limit.
> 
> Expose a new PMD API rte_pmd_mlx5_txq_rate_limit_query() that
> queries txq_ctrl->rl for driver state and mlx5_devx_cmd_query_sq()
> for the FW packet_pacing_rate_limit_index field.
> 
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---

This was obvious to me, but not AI...


The testpmd query command is implemented as an mlx5-specific 
 mlx5 port <id> txq <id> rate show 
command, but per-queue rate limiting is an
ethdev-level feature (rte_eth_set_queue_rate_limit exists for any PMD).
The query side should also be generic — add a testpmd command like
  show port <id> txq <id> rate
that calls the new
rte_eth_get_queue_rate_limit(). 


Once again, AI sees the trees not the forest!