From: Jakub Kicinski <kuba@kernel.org>
To: Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>
Cc: jan.petrous@oss.nxp.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>,
NXP S32 Linux Team <s32@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, rmk+kernel@armlinux.org.uk,
vladimir.oltean@nxp.com, boon.khai.ng@altera.com
Subject: Re: [PATCH v8 1/5] net: stmmac: Use helper macro for loop over queue-based arrays
Date: Wed, 11 Mar 2026 20:37:07 -0700 [thread overview]
Message-ID: <20260311203707.1d5ba94c@kernel.org> (raw)
In-Reply-To: <20260309-dwmac_multi_irq-v8-1-f0cc5bc811a7@oss.nxp.com>
On Mon, 09 Mar 2026 18:55:20 +0100 Jan Petrous via B4 Relay wrote:
> The stmmac driver contains similar pattern for processing queue-based
> arrays, ie. interrupt lines, etc. Factor out the for loop and provide
> a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
This is macro is neither shorter nor more readable.
I really don't see any benefit here..
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-12 3:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 17:55 [PATCH v8 0/5] Support multi-channel IRQs in stmmac platform drivers Jan Petrous (OSS)
2026-03-09 17:55 ` Jan Petrous via B4 Relay
2026-03-09 17:55 ` [PATCH v8 1/5] net: stmmac: Use helper macro for loop over queue-based arrays Jan Petrous (OSS)
2026-03-09 17:55 ` Jan Petrous via B4 Relay
2026-03-12 3:37 ` Jakub Kicinski [this message]
2026-03-12 7:50 ` Jan Petrous
2026-03-09 17:55 ` [PATCH v8 2/5] net: stmmac: platform: read channels irq Jan Petrous (OSS)
2026-03-09 17:55 ` Jan Petrous via B4 Relay
2026-03-09 17:55 ` [PATCH v8 3/5] arm64: dts: s32: set Ethernet channel irqs Jan Petrous (OSS)
2026-03-09 17:55 ` Jan Petrous via B4 Relay
2026-03-09 17:55 ` [PATCH v8 4/5] dt-bindings: net: nxp,s32-dwmac: Declare per-queue interrupts Jan Petrous (OSS)
2026-03-09 17:55 ` Jan Petrous via B4 Relay
2026-03-09 17:55 ` [PATCH v8 5/5] stmmac: s32: enable support for Multi-IRQ mode Jan Petrous (OSS)
2026-03-09 17:55 ` Jan Petrous via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311203707.1d5ba94c@kernel.org \
--to=kuba@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=devnull+jan.petrous.oss.nxp.com@kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jan.petrous@oss.nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mbrugger@suse.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.