Re: [PATCH v3] module: print version for external modules in print_modules()

[Sami Tolvanen <samitolvanen@google.com>]

On Mon, Mar 09, 2026 at 11:31:28PM -0700, Christoph Hellwig wrote:
> On Tue, Mar 10, 2026 at 10:38:07AM +0800, Yafang Shao wrote:
> > For vmcores triggered by a driver bug, the system calls print_modules() to
> > list the loaded modules. However, print_modules() does not output module
> > version information.
> 
> And it should not.
> 
> >
> > Across a large fleet of servers, there are often many
> > different module versions running simultaneously, and we need to know which
> > driver version caused a given vmcore.
> 
> Then don't run extetrnal modules, which are not a first part citizen.
> Get your changeas upstream instead of just leeching the upstream
> developers work.

As much as I would like to see these modules upstreamed, distributions
do ship out-of-tree modules to users. If adding the OOT module version
to print_modules() helps folks better handle the resulting bug reports,
and maybe even indirectly keeps some of the noise away from upstream, I
feel it's worth the small maintenance burden from this change.

Sami