From: Peter Zijlstra <peterz@infradead.org>
To: Carlos Llamas <cmllamas@google.com>
Cc: "Sami Tolvanen" <samitolvanen@google.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Jason Baron" <jbaron@akamai.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"James Clark" <james.clark@linaro.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Valentin Schneider" <vschneid@redhat.com>,
"Kees Cook" <kees@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
"Nathan Chancellor" <nathan@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
"Jens Remus" <jremus@linux.ibm.com>,
"Juergen Gross" <jgross@suse.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"David Kaplan" <david.kaplan@amd.com>,
"Lukas Bulwahn" <lukas.bulwahn@redhat.com>,
"Jinjie Ruan" <ruanjinjie@huawei.com>,
"James Morse" <james.morse@arm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Sean Christopherson" <seanjc@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
"Will McVicker" <willmcvicker@google.com>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
"open list:PERFORMANCE EVENTS SUBSYSTEM"
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH] static_call: use CFI-compliant return0 stubs
Date: Thu, 12 Mar 2026 00:14:06 +0100 [thread overview]
Message-ID: <20260311231406.GZ606826@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260311225822.1565895-1-cmllamas@google.com>
On Wed, Mar 11, 2026 at 10:57:40PM +0000, Carlos Llamas wrote:
> Architectures with !HAVE_STATIC_CALL (such as arm64) rely on the generic
> static_call implementation via indirect calls. In particular, users of
> DEFINE_STATIC_CALL_RET0, default to the generic __static_call_return0
> stub to optimize the unset path.
>
> However, __static_call_return0 has a fixed signature of "long (*)(void)"
> which may not match the expected prototype at callsites. This triggers
> CFI failures when CONFIG_CFI is enabled. A trivial linux-perf command
> does it:
*sigh*...
And ARM64 can't really do the inline thing because its immediate range
is too small and it all turns into a mess constructing the address in a
register and doing an indirect call anyway, right?
I'll stare at it in more detail tomorrow.
next prev parent reply other threads:[~2026-03-11 23:14 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 2:07 [PATCH v4 00/17] perf: KVM: Fix, optimize, and clean up callbacks Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 01/17] perf: Protect perf_guest_cbs with RCU Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 7:26 ` Paolo Bonzini
2021-11-11 7:26 ` Paolo Bonzini
2021-11-11 7:26 ` Paolo Bonzini
2021-11-11 10:47 ` Peter Zijlstra
2021-11-11 10:47 ` Peter Zijlstra
2021-11-11 10:47 ` Peter Zijlstra
2021-11-12 7:55 ` Paolo Bonzini
2021-11-12 7:55 ` Paolo Bonzini
2021-11-12 7:55 ` Paolo Bonzini
2021-11-11 2:07 ` [PATCH v4 02/17] KVM: x86: Register perf callbacks after calling vendor's hardware_setup() Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 03/17] KVM: x86: Register Processor Trace interrupt hook iff PT enabled in guest Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 04/17] perf: Stop pretending that perf can handle multiple guest callbacks Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 05/17] perf: Drop dead and useless guest "support" from arm, csky, nds32 and riscv Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 06/17] perf/core: Rework guest callbacks to prepare for static_call support Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 07/17] perf: Add wrappers for invoking guest callbacks Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 08/17] perf: Force architectures to opt-in to " Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 09/17] perf/core: Use static_call to optimize perf_guest_info_callbacks Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2022-02-02 18:43 ` Sean Christopherson
2022-02-04 17:35 ` Sami Tolvanen
2022-02-06 13:08 ` Peter Zijlstra
2022-02-06 18:45 ` Kees Cook
2022-02-06 20:28 ` Peter Zijlstra
2022-02-07 2:55 ` Kees Cook
2022-02-18 22:35 ` Will McVicker
2022-08-24 16:45 ` Sean Christopherson
2026-03-09 19:27 ` Carlos Llamas
2026-03-09 22:31 ` Sami Tolvanen
2026-03-10 3:26 ` Carlos Llamas
2026-03-11 22:57 ` [PATCH] static_call: use CFI-compliant return0 stubs Carlos Llamas
2026-03-11 23:14 ` Peter Zijlstra [this message]
2026-03-12 0:16 ` Carlos Llamas
2026-03-12 7:40 ` Ard Biesheuvel
2026-03-12 8:07 ` Peter Zijlstra
2026-03-12 17:18 ` Carlos Llamas
2026-03-11 23:05 ` [PATCH v4 09/17] perf/core: Use static_call to optimize perf_guest_info_callbacks Carlos Llamas
2021-11-11 2:07 ` [PATCH v4 10/17] KVM: x86: Drop current_vcpu for kvm_running_vcpu + kvm_arch_vcpu variable Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 11/17] KVM: x86: More precisely identify NMI from guest when handling PMI Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 12/17] KVM: Move x86's perf guest info callbacks to generic KVM Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 13/17] KVM: x86: Move Intel Processor Trace interrupt handler to vmx.c Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 14/17] KVM: arm64: Convert to the generic perf callbacks Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` [PATCH v4 15/17] KVM: arm64: Hide kvm_arm_pmu_available behind CONFIG_HW_PERF_EVENTS=y Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 21:49 ` Marc Zyngier
2021-11-11 21:49 ` Marc Zyngier
2021-11-11 21:49 ` Marc Zyngier
2021-11-11 2:07 ` [PATCH v4 16/17] KVM: arm64: Drop perf.c and fold its tiny bits of code into arm.c Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 21:49 ` Marc Zyngier
2021-11-11 21:49 ` Marc Zyngier
2021-11-11 21:49 ` Marc Zyngier
2021-11-11 2:07 ` [PATCH v4 17/17] perf: Drop guest callback (un)register stubs Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 2:07 ` Sean Christopherson
2021-11-11 11:19 ` [PATCH v4 00/17] perf: KVM: Fix, optimize, and clean up callbacks Peter Zijlstra
2021-11-11 11:19 ` Peter Zijlstra
2021-11-11 11:19 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311231406.GZ606826@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aliceryhl@google.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=cmllamas@google.com \
--cc=conor.dooley@microchip.com \
--cc=david.kaplan@amd.com \
--cc=dietmar.eggemann@arm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=james.morse@arm.com \
--cc=jbaron@akamai.com \
--cc=jgross@suse.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=kernel-team@android.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=ruanjinjie@huawei.com \
--cc=samitolvanen@google.com \
--cc=seanjc@google.com \
--cc=tan.shaopeng@jp.fujitsu.com \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=thuth@redhat.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.