All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Sterba <dsterba@suse.cz>
Cc: Qingfang Deng <dqfext@gmail.com>, Jiri Kosina <jikos@kernel.org>,
	David Sterba <dsterba@suse.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Stephen Blackheath <stephen@symmetric.co.nz>,
	Ben Martel <benm@symmetric.co.nz>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: ipwireless: fix memory leak in do_go_offline()
Date: Thu, 12 Mar 2026 14:40:08 +0100	[thread overview]
Message-ID: <2026031201-shape-recital-5b38@gregkh> (raw)
In-Reply-To: <20260312120036.GF5735@suse.cz>

On Thu, Mar 12, 2026 at 01:00:36PM +0100, David Sterba wrote:
> On Fri, Mar 06, 2026 at 11:40:58AM +0800, Qingfang Deng wrote:
> > The ppp_channel is allocated and registered in do_go_online(). But when
> > the channel is unregistered in do_go_offline(), the driver forgets to
> > release its memory. This leads to a memory leak each time the network
> > goes online and then offline.
> > 
> > Fix this by adding a kfree call after unregistering the channel.
> > 
> > Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem")
> > Signed-off-by: Qingfang Deng <dqfext@gmail.com>
> 
> Thanks, but the driver is going to be deleted.
> 

Great, can you send a patch to do that?

thanks,

greg k-h

  reply	other threads:[~2026-03-12 13:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06  3:40 [PATCH] tty: ipwireless: fix memory leak in do_go_offline() Qingfang Deng
2026-03-12 12:00 ` David Sterba
2026-03-12 13:40   ` Greg Kroah-Hartman [this message]
2026-04-10  4:01   ` Qingfang Deng
2026-04-10  4:54     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031201-shape-recital-5b38@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=benm@symmetric.co.nz \
    --cc=dqfext@gmail.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=jikos@kernel.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=stephen@symmetric.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.