From: Nathan Rebello <nathan.c.rebello@gmail.com>
To: linux-usb@vger.kernel.org, heikki.krogerus@linux.intel.com,
kyungtae.kim@dartmouth.edu, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] usb: typec: ucsi: validate connector number in ucsi_connector_change()
Date: Thu, 12 Mar 2026 01:44:43 -0400 [thread overview]
Message-ID: <20260312054443.573-1-nathan.c.rebello@gmail.com> (raw)
In-Reply-To: <2026031206-many-halt-cb1b@gregkh>
On Thu, 12 Mar 2026 at 06:03:33 +0100, Greg KH wrote:
> Yes, please do that as we need central points where data is validated to
> help keep the code sane.
Thanks. On closer inspection, ucsi_notify_common() is not actually the
sole entry point -- ucsi_register() also calls ucsi_connector_change()
directly when reading CCI at the end of init, and ucsi_yoga_c630.c
calls it from its own notifier.
The true single central point is ucsi_connector_change() itself. v2
adds the bounds check there, before the array dereference, which covers
all callers.
Will send v2 shortly.
Nathan Rebello
next prev parent reply other threads:[~2026-03-12 5:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 16:49 [PATCH 0/2] usb: typec: ucsi: fix input validation in UCSI core Nathan Rebello
2026-02-19 16:49 ` [PATCH 1/2] usb: typec: ucsi: validate connector number in ucsi_connector_change() Nathan Rebello
2026-02-20 6:09 ` Greg KH
2026-02-20 6:34 ` Nathan Rebello
2026-02-20 6:53 ` Greg KH
2026-03-11 13:10 ` Greg KH
2026-03-11 21:49 ` Nathan Rebello
2026-03-12 5:03 ` Greg KH
2026-03-12 5:44 ` Nathan Rebello [this message]
2026-02-19 16:49 ` [PATCH 2/2] usb: typec: ucsi: clamp returned length in ucsi_run_command() Nathan Rebello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312054443.573-1-nathan.c.rebello@gmail.com \
--to=nathan.c.rebello@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyungtae.kim@dartmouth.edu \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.