From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C543D2264C7 for ; Thu, 12 Mar 2026 10:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309683; cv=none; b=sq0QltrRUrulmQEzBZsSzFfvDqlisRzxfBI/arcyKejDUmWvw4alnAqI9ntBalSRuMJ7hVz7DfkMYH2VNJEAd/tMy3Ynrr5sL0L6ZfKsCUV6nCOKGV/RfjcEAo/FcEV2Ik5u03rSHzWYdpqdTVr/GW7e34mVYUrxCF619xYOsf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309683; c=relaxed/simple; bh=0Bmx5aRzPgXE+na5gUveDW3BKdW390tNcZ9vmX0okOQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kROprvEUeWfbJ2pQXcEMvVGLy9cw0ahivcW/CCljI+27SJZre+4cTsxBXsP7si3Yai6QjpGA6u7Fo6iP76LCbwIqOxthQO3+k9ko6NtGf8MGYSiz3ajTu4PiiMBTtaMbtuVu/xQlE8R2NGyaIIGt8TbwfDMIG373YbIkAmFiX4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=gwL+4Vhw; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gwL+4Vhw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N8F0BybGBNsXbDqd6JoOyle9nXITElv8dljrhZhGuyk=; b=gwL+4Vhw+x2ixKtEOeGdAjLTfi OKNJ+g9VkgRbIGXWTUfVFlzWINSED38UwBUJjhCVDS8nsKUjjMUA0Hz2dbmx3KWsA4b9hRoFkmP1e yS74SgunNL72PjfFxyf98FSxRvd1ReEHCt19WfZLM7YFA9jRVEpH/U8quXBj5ekdjG8mpdhahfWz2 LrJgse4BSbSSX1m+wzCthE97WWUMDiSqF3qItHiiIge85y7xotSayzl3eMk9PfAlRD0xRpAkz2P9H RzRfxRsTm5vWEa1ITaL7Cmz3EYzxiGwkuKXPQXs0gatoyam9x41nFhhANc0ISVQMnl7uUyhEYN7iD frY0tQig==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0cqr-00000000skS-3NQy; Thu, 12 Mar 2026 10:01:09 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id DF235301150; Thu, 12 Mar 2026 11:01:08 +0100 (CET) Date: Thu, 12 Mar 2026 11:01:08 +0100 From: Peter Zijlstra To: K Prateek Nayak Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Valentin Schneider , linux-kernel@vger.kernel.org, Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Chen Yu , Shrikanth Hegde , Li Chen , "Gautham R. Shenoy" Subject: Re: [PATCH v4 1/9] sched/topology: Compute sd_weight considering cpuset partitions Message-ID: <20260312100108.GA1282955@noisy.programming.kicks-ass.net> References: <20260312044434.1974-1-kprateek.nayak@amd.com> <20260312044434.1974-2-kprateek.nayak@amd.com> <20260312093428.GX1282955@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 12, 2026 at 03:29:09PM +0530, K Prateek Nayak wrote: > Hello Peter, > > On 3/12/2026 3:04 PM, Peter Zijlstra wrote: > > Why not like so? > > > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > > index 061f8c85f555..79bab80af8f2 100644 > > --- a/kernel/sched/topology.c > > +++ b/kernel/sched/topology.c > > @@ -1645,13 +1645,17 @@ sd_init(struct sched_domain_topology_level *tl, > > struct cpumask *sd_span; > > u64 now = sched_clock(); > > > > - sd_weight = cpumask_weight(tl->mask(tl, cpu)); > > + sd_span = sched_domain_span(sd); > > + cpumask_and(sd_span, cpu_map, tl->mask(tl, cpu)); > > + sd_weight = cpumask_weight(sd_span); > > + sd_id = cpumask_first(sd_span); > > > > if (tl->sd_flags) > > sd_flags = (*tl->sd_flags)(); > > if (WARN_ONCE(sd_flags & ~TOPOLOGY_SD_FLAGS, > > - "wrong sd_flags in topology description\n")) > > + "wrong sd_flags in topology description\n")) > > sd_flags &= TOPOLOGY_SD_FLAGS; > > + sd_flags |= asym_cpu_capacity_classify(sd_span, cpu_map); > > > That can work too. Since sd_span is is just a variable array at the > end of sched_domain, it shouldn't be affected by the assignment below. > I'll update this in the next version. I've already fixed it up, was about to go push it out to queue/sched/core.