Re: [PATCH RFC net-next v2 1/2] hsr: Allow to send a specific port and with HSR header

[kernel test robot <lkp@intel.com>]

Hi Sebastian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 3daa4f5dc6cc1ac1ab2f95b5b4c16bc5fb87f48f]

url:    https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/hsr-Allow-to-send-a-specific-port-and-with-HSR-header/20260310-001021
base:   3daa4f5dc6cc1ac1ab2f95b5b4c16bc5fb87f48f
patch link:    https://lore.kernel.org/r/20260309-hsr_ptp-v2-1-798262aad3a4%40linutronix.de
patch subject: [PATCH RFC net-next v2 1/2] hsr: Allow to send a specific port and with HSR header
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260312/202603121144.VLHSROR4-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260312/202603121144.VLHSROR4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603121144.VLHSROR4-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from net/dsa/dsa.c:12:
>> include/linux/if_hsr.h:54:46: warning: 'struct sk_buff' declared inside parameter list will not be visible outside of this definition or declaration
      54 | static inline bool hsr_skb_has_header(struct sk_buff *skb)
         |                                              ^~~~~~~
   include/linux/if_hsr.h: In function 'hsr_skb_has_header':
>> include/linux/if_hsr.h:58:19: error: implicit declaration of function 'skb_ext_find' [-Wimplicit-function-declaration]
      58 |         ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
         |                   ^~~~~~~~~~~~
>> include/linux/if_hsr.h:58:37: error: 'SKB_EXT_HSR' undeclared (first use in this function)
      58 |         ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
         |                                     ^~~~~~~~~~~
   include/linux/if_hsr.h:58:37: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/if_hsr.h: At top level:
   include/linux/if_hsr.h:64:52: warning: 'struct sk_buff' declared inside parameter list will not be visible outside of this definition or declaration
      64 | static inline unsigned int hsr_skb_has_port(struct sk_buff *skb)
         |                                                    ^~~~~~~
   include/linux/if_hsr.h: In function 'hsr_skb_has_port':
   include/linux/if_hsr.h:71:37: error: 'SKB_EXT_HSR' undeclared (first use in this function)
      71 |         ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
         |                                     ^~~~~~~~~~~
   include/linux/if_hsr.h: At top level:
   include/linux/if_hsr.h:77:51: warning: 'struct sk_buff' declared inside parameter list will not be visible outside of this definition or declaration
      77 | static inline bool hsr_skb_get_header_port(struct sk_buff *skb, bool *header,
         |                                                   ^~~~~~~
   include/linux/if_hsr.h: In function 'hsr_skb_get_header_port':
   include/linux/if_hsr.h:85:37: error: 'SKB_EXT_HSR' undeclared (first use in this function)
      85 |         ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
         |                                     ^~~~~~~~~~~
   include/linux/if_hsr.h: At top level:
   include/linux/if_hsr.h:94:51: warning: 'struct sk_buff' declared inside parameter list will not be visible outside of this definition or declaration
      94 | static inline bool hsr_skb_add_header_port(struct sk_buff *skb, bool header,
         |                                                   ^~~~~~~
   include/linux/if_hsr.h: In function 'hsr_skb_add_header_port':
>> include/linux/if_hsr.h:99:19: error: implicit declaration of function 'skb_ext_add' [-Wimplicit-function-declaration]
      99 |         ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
         |                   ^~~~~~~~~~~
   include/linux/if_hsr.h:99:36: error: 'SKB_EXT_HSR' undeclared (first use in this function)
      99 |         ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
         |                                    ^~~~~~~~~~~
   In file included from include/net/net_namespace.h:44,
                    from include/linux/netdevice.h:38,
                    from net/dsa/dsa.c:15:
   include/linux/skbuff.h: At top level:
>> include/linux/skbuff.h:5034:7: error: conflicting types for 'skb_ext_add'; have 'void *(struct sk_buff *, enum skb_ext_id)'
    5034 | void *skb_ext_add(struct sk_buff *skb, enum skb_ext_id id);
         |       ^~~~~~~~~~~
   include/linux/if_hsr.h:99:19: note: previous implicit declaration of 'skb_ext_add' with type 'int()'
      99 |         ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
         |                   ^~~~~~~~~~~
>> include/linux/skbuff.h:5079:21: error: conflicting types for 'skb_ext_find'; have 'void *(const struct sk_buff *, enum skb_ext_id)'
    5079 | static inline void *skb_ext_find(const struct sk_buff *skb, enum skb_ext_id id)
         |                     ^~~~~~~~~~~~
   include/linux/if_hsr.h:58:19: note: previous implicit declaration of 'skb_ext_find' with type 'int()'
      58 |         ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
         |                   ^~~~~~~~~~~~


vim +/skb_ext_find +58 include/linux/if_hsr.h

    45	
    46	#if IS_ENABLED(CONFIG_HSR)
    47	extern bool is_hsr_master(struct net_device *dev);
    48	extern int hsr_get_version(struct net_device *dev, enum hsr_version *ver);
    49	struct net_device *hsr_get_port_ndev(struct net_device *ndev,
    50					     enum hsr_port_type pt);
    51	int hsr_get_port_type(struct net_device *hsr_dev, struct net_device *dev,
    52			      enum hsr_port_type *type);
    53	
  > 54	static inline bool hsr_skb_has_header(struct sk_buff *skb)
    55	{
    56		struct hsr_ptp_ext *ptp_ext;
    57	
  > 58		ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
    59		if (!ptp_ext)
    60			return false;
    61		return ptp_ext->header;
    62	}
    63	
    64	static inline unsigned int hsr_skb_has_port(struct sk_buff *skb)
    65	{
    66		struct hsr_ptp_ext *ptp_ext;
    67	
    68		if (!skb)
    69			return 0;
    70	
    71		ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
    72		if (!ptp_ext)
    73			return 0;
    74		return ptp_ext->port;
    75	}
    76	
    77	static inline bool hsr_skb_get_header_port(struct sk_buff *skb, bool *header,
    78						   enum hsr_port_type *port_type)
    79	{
    80		struct hsr_ptp_ext *ptp_ext;
    81	
    82		*port_type = HSR_PT_NONE;
    83		*header = false;
    84	
  > 85		ptp_ext = skb_ext_find(skb, SKB_EXT_HSR);
    86		if (!ptp_ext)
    87			return false;
    88	
    89		*port_type = ptp_ext->port;
    90		*header = ptp_ext->header;
    91		return true;
    92	}
    93	
    94	static inline bool hsr_skb_add_header_port(struct sk_buff *skb, bool header,
    95						   enum hsr_port_type port)
    96	{
    97		struct hsr_ptp_ext *ptp_ext;
    98	
  > 99		ptp_ext = skb_ext_add(skb, SKB_EXT_HSR);
   100		if (!ptp_ext)
   101			return false;
   102		ptp_ext->port = port;
   103		ptp_ext->header = header;
   104		return true;
   105	}
   106	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki