From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Vineeth Pillai (Google)" <vineeth@bitbyteword.org>,
"Dmitry Ilvokhin" <d@ilvokhin.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>, "Jens Axboe" <axboe@kernel.dk>,
io-uring@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
"Xin Long" <lucien.xin@gmail.com>,
"Jon Maloy" <jmaloy@redhat.com>,
"Aaron Conole" <aconole@redhat.com>,
"Eelco Chaudron" <echaudro@redhat.com>,
"Ilya Maximets" <i.maximets@ovn.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-sctp@vger.kernel.org,
tipc-discussion@lists.sourceforge.net, dev@openvswitch.org,
"Oded Gabbay" <ogabbay@kernel.org>,
"Koby Elbaz" <koby.elbaz@intel.com>,
dri-devel@lists.freedesktop.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
"Huang Rui" <ray.huang@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Len Brown" <lenb@kernel.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
linux-pm@vger.kernel.org,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Christian König" <christian.koenig@amd.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org,
"Eddie James" <eajames@linux.ibm.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
linux-fsi@lists.ozlabs.org, "David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Philipp Stanner" <phasta@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
amd-gfx@lists.freedesktop.org, "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
linux-input@vger.kernel.org,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-spi@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, "Chris Mason" <clm@fb.com>,
"David Sterba" <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites
Date: Thu, 12 Mar 2026 16:54:29 +0100 [thread overview]
Message-ID: <20260312155429.GC1282955@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com>
On Thu, Mar 12, 2026 at 11:49:23AM -0400, Mathieu Desnoyers wrote:
> On 2026-03-12 11:40, Steven Rostedt wrote:
> > On Thu, 12 Mar 2026 11:28:07 -0400
> > Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> >
> > > > Note, Vineeth came up with the naming. I would have done "do" but when I
> > > > saw "invoke" I thought it sounded better.
> > >
> > > It works as long as you don't have a tracing subsystem called
> > > "invoke", then you get into identifier clash territory.
> >
> > True. Perhaps we should do the double underscore trick.
> >
> > Instead of: trace_invoke_foo()
> >
> > use: trace_invoke__foo()
> >
> >
> > Which will make it more visible to what the trace event is.
> >
> > Hmm, we probably should have used: trace__foo() for all tracepoints, as
> > there's still functions that are called trace_foo() that are not
> > tracepoints :-p
>
> One certain way to eliminate identifier clash would be to go for a
> prefix to "trace_", e.g.
Oh, I know!, call them __do_trace_##foo().
/me runs like hell
next prev parent reply other threads:[~2026-03-12 15:54 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 15:04 [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites Vineeth Pillai (Google)
2026-03-12 15:04 ` [PATCH 01/15] tracepoint: Add trace_invoke_##name() API Vineeth Pillai (Google)
2026-03-12 15:12 ` Steven Rostedt
2026-03-12 15:39 ` Vineeth Remanan Pillai
2026-03-12 15:53 ` Peter Zijlstra
2026-03-12 16:05 ` Vineeth Remanan Pillai
2026-03-14 0:24 ` Keith Busch
2026-03-12 15:04 ` [PATCH 02/15] kernel: Use trace_invoke_##name() at guarded tracepoint call sites Vineeth Pillai (Google)
2026-03-12 15:04 ` [PATCH 03/15] io_uring: " Vineeth Pillai (Google)
2026-03-12 15:24 ` Keith Busch
2026-03-12 15:38 ` Steven Rostedt
2026-03-18 14:51 ` Vineeth Remanan Pillai
2026-03-12 15:04 ` [PATCH 04/15] net: " Vineeth Pillai (Google)
2026-03-12 15:31 ` Aaron Conole
2026-03-18 13:40 ` Vineeth Remanan Pillai
2026-03-18 14:13 ` Vineeth Remanan Pillai
2026-03-17 10:34 ` Paolo Abeni
2026-03-12 15:05 ` [PATCH 05/15] accel/habanalabs: " Vineeth Pillai (Google)
2026-03-12 15:05 ` [PATCH 06/15] cpufreq: " Vineeth Pillai (Google)
2026-03-12 18:58 ` Rafael J. Wysocki
2026-03-13 6:07 ` Viresh Kumar
2026-03-12 15:05 ` [PATCH 07/15] devfreq: " Vineeth Pillai (Google)
2026-03-12 15:05 ` [PATCH 08/15] dma-buf: " Vineeth Pillai (Google)
2026-03-12 15:05 ` [PATCH 09/15] fsi: " Vineeth Pillai (Google)
2026-03-12 15:05 ` [PATCH 10/15] drm: " Vineeth Pillai (Google)
2026-03-12 15:05 ` [PATCH 11/15] HID: " Vineeth Pillai (Google)
2026-03-12 15:05 ` [PATCH 12/15] i2c: " Vineeth Pillai (Google)
2026-03-12 16:50 ` Wolfram Sang
2026-03-12 15:05 ` [PATCH 13/15] spi: " Vineeth Pillai (Google)
2026-03-12 15:34 ` Mark Brown
2026-03-12 15:42 ` Steven Rostedt
2026-03-12 16:54 ` Mark Brown
2026-03-12 17:00 ` Steven Rostedt
2026-03-12 20:05 ` Mark Brown
2026-03-12 15:05 ` [PATCH 14/15] scsi: ufs: " Vineeth Pillai (Google)
2026-03-12 15:05 ` [PATCH 15/15] btrfs: " Vineeth Pillai (Google)
2026-03-13 11:57 ` David Sterba
2026-03-12 15:12 ` [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded " Mathieu Desnoyers
2026-03-12 15:23 ` Steven Rostedt
2026-03-12 15:28 ` Mathieu Desnoyers
2026-03-12 15:40 ` Steven Rostedt
2026-03-12 15:49 ` Mathieu Desnoyers
2026-03-12 15:54 ` Peter Zijlstra [this message]
2026-03-12 15:57 ` Mathieu Desnoyers
2026-03-12 16:08 ` Vineeth Remanan Pillai
2026-03-12 16:54 ` Andrii Nakryiko
2026-03-12 17:02 ` Steven Rostedt
2026-03-13 14:02 ` Vineeth Remanan Pillai
2026-03-17 16:00 ` Steven Rostedt
2026-03-17 16:02 ` Mathieu Desnoyers
2026-03-18 10:58 ` Vineeth Remanan Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312155429.GC1282955@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=aconole@redhat.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrew@codeconstruct.com.au \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bentiss@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=christian.koenig@amd.com \
--cc=clm@fb.com \
--cc=cw00.choi@samsung.com \
--cc=d@ilvokhin.com \
--cc=dakr@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=eajames@linux.ibm.com \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=gautham.shenoy@amd.com \
--cc=harry.wentland@amd.com \
--cc=i.maximets@ovn.org \
--cc=io-uring@vger.kernel.org \
--cc=jikos@kernel.org \
--cc=jmaloy@redhat.com \
--cc=joel@jms.id.au \
--cc=koby.elbaz@intel.com \
--cc=kuba@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lenb@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=mario.limonciello@amd.com \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=matthew.brost@intel.com \
--cc=mhiramat@kernel.org \
--cc=michael.hennerich@analog.com \
--cc=mingo@redhat.com \
--cc=myungjoo.ham@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ogabbay@kernel.org \
--cc=pabeni@redhat.com \
--cc=phasta@kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=rostedt@goodmis.org \
--cc=simona@ffwll.ch \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sumit.semwal@linaro.org \
--cc=sunpeng.li@amd.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=vineeth@bitbyteword.org \
--cc=viresh.kumar@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.