Re: [PATCH] mm: switch deferred split shrinker to list_lru

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260311154358.150977-1-hannes@cmpxchg.org>
References: <20260311154358.150977-1-hannes@cmpxchg.org>
TO: Johannes Weiner <hannes@cmpxchg.org>
TO: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: David Hildenbrand <david@redhat.com>
CC: Zi Yan <ziy@nvidia.com>
CC: "Liam R. Howlett" <Liam.Howlett@oracle.com>
CC: Usama Arif <usama.arif@linux.dev>
CC: Kiryl Shutsemau <kas@kernel.org>
CC: Dave Chinner <david@fromorbit.com>
CC: Roman Gushchin <roman.gushchin@linux.dev>
CC: linux-kernel@vger.kernel.org

Hi Johannes,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Johannes-Weiner/mm-switch-deferred-split-shrinker-to-list_lru/20260312-000508
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20260311154358.150977-1-hannes%40cmpxchg.org
patch subject: [PATCH] mm: switch deferred split shrinker to list_lru
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago
config: parisc-randconfig-r073-20260312 (https://download.01.org/0day-ci/archive/20260312/202603121741.Y8GG0oCq-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 9.5.0
smatch: v0.5.0-9004-gb810ac53

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202603121741.Y8GG0oCq-lkp@intel.com/

smatch warnings:
mm/list_lru.c:24 lock_list_lru() warn: mixing irqsave and irq
mm/list_lru.c:35 unlock_list_lru() warn: mixing irqsave and irq

vim +24 mm/list_lru.c

c0a5b560938a0f2 Vladimir Davydov 2015-02-12  17  
09adc9da498223d Johannes Weiner  2026-03-11  18  static inline void lock_list_lru(struct list_lru_one *l, bool irq,
09adc9da498223d Johannes Weiner  2026-03-11  19  				 unsigned long *irq_flags)
09adc9da498223d Johannes Weiner  2026-03-11  20  {
09adc9da498223d Johannes Weiner  2026-03-11  21  	if (irq_flags)
09adc9da498223d Johannes Weiner  2026-03-11  22  		spin_lock_irqsave(&l->lock, *irq_flags);
09adc9da498223d Johannes Weiner  2026-03-11  23  	else if (irq)
09adc9da498223d Johannes Weiner  2026-03-11 @24  		spin_lock_irq(&l->lock);
09adc9da498223d Johannes Weiner  2026-03-11  25  	else
09adc9da498223d Johannes Weiner  2026-03-11  26  		spin_lock(&l->lock);
09adc9da498223d Johannes Weiner  2026-03-11  27  }
09adc9da498223d Johannes Weiner  2026-03-11  28  
09adc9da498223d Johannes Weiner  2026-03-11  29  static inline void unlock_list_lru(struct list_lru_one *l, bool irq,
09adc9da498223d Johannes Weiner  2026-03-11  30  				   unsigned long *irq_flags)
09adc9da498223d Johannes Weiner  2026-03-11  31  {
09adc9da498223d Johannes Weiner  2026-03-11  32  	if (irq_flags)
09adc9da498223d Johannes Weiner  2026-03-11  33  		spin_unlock_irqrestore(&l->lock, *irq_flags);
09adc9da498223d Johannes Weiner  2026-03-11  34  	else if (irq)
09adc9da498223d Johannes Weiner  2026-03-11 @35  		spin_unlock_irq(&l->lock);
09adc9da498223d Johannes Weiner  2026-03-11  36  	else
09adc9da498223d Johannes Weiner  2026-03-11  37  		spin_unlock(&l->lock);
09adc9da498223d Johannes Weiner  2026-03-11  38  }
09adc9da498223d Johannes Weiner  2026-03-11  39  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki