From: Boris Brezillon <boris.brezillon@collabora.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>,
"loic.molinari@collabora.com" <loic.molinari@collabora.com>,
"willy@infradead.org" <willy@infradead.org>,
"frank.binns@imgtec.com" <frank.binns@imgtec.com>,
"matt.coster@imgtec.com" <matt.coster@imgtec.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap
Date: Fri, 13 Mar 2026 12:56:44 +0100 [thread overview]
Message-ID: <20260313125644.65131b27@fedora> (raw)
In-Reply-To: <f3384342-cdc5-4260-b670-4ffde76a2802@suse.de>
On Fri, 13 Mar 2026 11:29:47 +0100
Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Hi
>
> Am 13.03.26 um 11:18 schrieb Boris Brezillon:
> [...]
> >>>>> + if (drm_WARN_ON(obj->dev, !shmem->pages || page_offset >= num_pages))
> >>>>> + return VM_FAULT_SIGBUS;
> >>>>> +
> >>>>> + file_update_time(vma->vm_file);
> >>>>> +
> >>>>> + folio_mark_dirty(page_folio(shmem->pages[page_offset]));
> > Do we need a folio_mark_dirty_lock() here?
>
> There is a helper for that with some documentation. [1]
This [1] seems to solve the problem for me. Still unsure about the
folio_mark_dirty_lock vs folio_mark_dirty though.
[1]https://yhbt.net/lore/dri-devel/20260312155027.1682606-1-pedrodemargomes@gmail.com/
next prev parent reply other threads:[~2026-03-13 11:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 11:42 [PATCH v4 0/6] drm/gem-shmem: Track page accessed/dirty status Thomas Zimmermann
2026-02-27 11:42 ` [PATCH v4 1/6] drm/gem-shmem: Use obj directly where appropriate in fault handler Thomas Zimmermann
2026-02-27 11:42 ` [PATCH v4 2/6] drm/gem-shmem: Test for existence of page in mmap " Thomas Zimmermann
2026-02-27 11:42 ` [PATCH v4 3/6] drm/gem-shmem: Return vm_fault_t from drm_gem_shmem_try_map_pmd() Thomas Zimmermann
2026-02-27 11:42 ` [PATCH v4 4/6] drm/gem-shmem: Refactor drm_gem_shmem_try_map_pmd() Thomas Zimmermann
2026-02-27 11:42 ` [PATCH v4 5/6] drm/gem-shmem: Track folio accessed/dirty status in mmap Thomas Zimmermann
2026-03-12 17:36 ` Tommaso Merciai
2026-03-12 17:46 ` Biju Das
2026-03-13 6:44 ` Biju Das
2026-03-13 8:00 ` Thomas Zimmermann
2026-03-13 8:41 ` Biju Das
2026-03-13 10:03 ` Biju Das
2026-03-13 10:18 ` Boris Brezillon
2026-03-13 10:29 ` Thomas Zimmermann
2026-03-13 10:33 ` Biju Das
2026-03-13 10:52 ` Boris Brezillon
2026-03-13 11:56 ` Boris Brezillon [this message]
2026-03-13 12:04 ` Biju Das
2026-03-13 12:18 ` Boris Brezillon
2026-03-13 12:43 ` Boris Brezillon
2026-03-13 12:55 ` Boris Brezillon
2026-03-13 17:45 ` Boris Brezillon
2026-03-14 9:42 ` Biju Das
2026-03-19 14:17 ` Biju Das
2026-03-19 14:50 ` Boris Brezillon
2026-03-19 14:53 ` Biju Das
2026-03-16 8:45 ` Thomas Zimmermann
2026-03-16 9:36 ` Boris Brezillon
2026-03-16 10:22 ` Thomas Zimmermann
2026-03-16 10:53 ` Boris Brezillon
2026-03-16 15:30 ` Boris Brezillon
2026-03-13 8:33 ` Thomas Zimmermann
2026-03-13 8:47 ` Biju Das
2026-03-13 9:24 ` Tommaso Merciai
2026-02-27 11:42 ` [PATCH v4 6/6] drm/gem-shmem: Track folio accessed/dirty status in vmap Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313125644.65131b27@fedora \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=linux-mm@kvack.org \
--cc=loic.molinari@collabora.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.