From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32DB640DFD6 for ; Fri, 13 Mar 2026 18:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773425827; cv=none; b=WAUguXYhwQLvzYHMn2ZgQHlpTiUKtu69gCf5bNKXtwNO3K7XoAZScXDPs9bxrmRpyp4EoWBQh5SxX1XLyLiA4zxFW2BH9g9raidlZwPXX3XY7eUmQPM6KuMiDKerrCC+L+VXAlwSOi8rN37OdfK0Sd587D+KwBKA7icerwgZ6OY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773425827; c=relaxed/simple; bh=UVifXl92z4xbkFRi1sUcFrraERrtykR+9ChQBVQvsDk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SAjAa9IYMsKdjvWFUxUiazOVg9ncXpI9/cU2nmEqVtf3Jm9kAxG26ovukewxfHHhX8c8gYpeydEhNUK28ITU12zeyoU3FB2KZUNMPXK/DfH7t7T1m5gs96sPiyZMGqXWkXo9mLWuFpfD1GX/CGmDi8jIx00TVTPGIMj3rUOmwMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=NNomMFI2; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="NNomMFI2" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8cb38e86cf2so263388885a.1 for ; Fri, 13 Mar 2026 11:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773425825; x=1774030625; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eCnCzzDljmZkhdaTY+hqn+9joXK1hXpoa9Aebbn9KOs=; b=NNomMFI2AiuD49yoSZTWnpU/xvnRmjmp+2c1PPdBDxfjiDK4sXGOX1mAmq3xtYBMjx ztd0oty5wl3PmhP2VZbIeySHCR0+vNRh7x3TZvCZZWt4kGYBA3cHnydxn8XLDTko1ecm +bqC5ihXIRpnz7iWCqBFqNCK0Edij9zfMUnNGTmoZiLntfe5JU0oDy76pCvHpznbDCTV LGNna2AJ6nh/603UV6bUJMVHecGYUfigqW96Egrdlf6huKwnInkkfcu0TwziyUJHEP58 nMDQJ5udFIEBzfSfPAlpc9acKgrGuBRRA9HC4yT72KtGb5/d6KtIylf2uCBDGrl9eOPN F9yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773425825; x=1774030625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eCnCzzDljmZkhdaTY+hqn+9joXK1hXpoa9Aebbn9KOs=; b=tBlsLHFAv/WNP/pYOlbsIpdFbSlvSxNfw2yXsCV7mVY3XBBqmiwRtXCEyhngUUIkal /wJMKSdz99rlg6m6YnwNcN62JQZyMSNxYTV38fQjux8BBv3Y70BANJjkKWMLbousHAs6 XNf167i5jCBlfH9C+/Z02l7BY3zCw50QwGgltbMNz5kati+9YQP607UjcmBbDLl9v+Es gXVV/PFXZhqFGbdqPzwZCt6qjZTjH1pRLRoUh1b4LwlKn4ZfVNGpxveehqSFXnaEmyxq 22/XbGQTTceScLB5HM6HcQlmRJMLjc2W+Fr1WlwVfsiD6wSTZhS4MSTMxPuRQVpLC0td HudQ== X-Forwarded-Encrypted: i=1; AJvYcCXSq1CXza3HIgq8spV14gd5QOFHXdZV3NAqgv2rpgc8HH1Seo1EapJ2MyaNNToLnEo4m4CLHT0XdGZ2amI=@vger.kernel.org X-Gm-Message-State: AOJu0YxQb0rgVbzZ2UhTFRkKBxakgTj3XIcHsfnRrRK4D8Tyn+rKqdvO xew7PBRhZVBJC/eXt0t2/OyYulMM6M7vkGpz4U5w/D0j68B8m5TJ5qhINfPoX0UYWN8= X-Gm-Gg: ATEYQzxTfX1lMBOqjhyNKnWPkgUim7V2fwYLPtC0NPdGFTk6bwF7gv2Nkmhd/5JRbLx zEMtCdnLj+HUPgx56fnWOF7jqb+BgX7bfJxZFbv8VhjmFe7GDYeK+SL4hXfBKrUsAucrDo9khpf phNJTbGS5QAlIaC98TcA5f7jh+BjwcKOmJlZ3OcZDrzgE10DGgrpZ8seriATqXYwiNYq0T69c89 nkdrf8pU/Q56U56DaunDaS0pQHJboSYbhtXXPp5qtdW5qdgA/YEtxma4GODoEeXN7cNpi7nO2bG J6JLGZ3WklmfXc+56vIpZggQIKu8oKXgx+HaLUOmvC0dMFWUMy/YKjwXzFYxjWHkOF6607clgNU JNVfI6cern5hFLzbmJb0eaUCPmdIbsq0Fe1E4wD1fhgqwxH0AmYkRtRwpArhy9Qc2SENrZxoePy vrJww2AfyjKMzRmlFiSI2iw/h8JDAF/7j2CM9gj79eenEuH2wWFg2txvfbUDIE4zPfZHhe4BSWr Xe5ykIk X-Received: by 2002:a05:620a:45ac:b0:8cd:9bf2:60e8 with SMTP id af79cd13be357-8cdb5b75fffmr555181785a.59.1773425824879; Fri, 13 Mar 2026 11:17:04 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cda215c2a9sm603999585a.46.2026.03.13.11.17.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 11:17:04 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w174J-00000007Lgx-2AyQ; Fri, 13 Mar 2026 15:17:03 -0300 Date: Fri, 13 Mar 2026 15:17:03 -0300 From: Jason Gunthorpe To: Pavan Chebbi Cc: michael.chan@broadcom.com, linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com Subject: Re: [PATCH v5 fwctl 4/5] fwctl/bnxt_fwctl: Add bnxt fwctl device Message-ID: <20260313181703.GI1704121@ziepe.ca> References: <20260226082318.525518-1-pavan.chebbi@broadcom.com> <20260226082318.525518-5-pavan.chebbi@broadcom.com> <20260313161418.GC1704121@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 13, 2026 at 11:44:05PM +0530, Pavan Chebbi wrote: > > > > Timeout is such a complicated thing to add to a HW RPC interface. Does > > bnxt do it right? Claude says no, and it looks compelling to me.. > > > > So don't give userspace an easy ability to trigger timeout, by > > lowering the timeout value, and causing corruption in the kernel. > > Yea I see what you are saying. I think it should be fine if > bnxtctl_fw_rpc() itself increases the timeout for the required > commands. Ah, you wanted to increase the timeout - yes, I think the kernel needs to do this itself to avoid userspace triggering timeouts that don't work right.. > I can make this change. But if I drop the "timeout" now, I won't need > the driver_data we discussed previously, at least until I actually add > the future enhancements. > So I guess I should defer that change to when I actually use > driver_data, right? Yes all that makes sense. Without timeout and the dma list thing there is no reason to wrapper the commands. Comme with some driver_data later if you find you need more info Jason